Skip to content

build: add standard-version and commitlint packages#675

Merged
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:chore-add-conventional-changelog
Jun 24, 2018
Merged

build: add standard-version and commitlint packages#675
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:chore-add-conventional-changelog

Conversation

@rafaelss95
Copy link
Copy Markdown
Collaborator

Adds:

  • standard-version - a package to generate changelog following specific (in our case Angular) conventions and tags;
  • commitlint - a package to validate commit messages (it will really improve the changelog generator). It was configured according to CONTRIBUTING.md;

@rafaelss95 rafaelss95 requested a review from mgechev June 24, 2018 04:07
@loktionov129
Copy link
Copy Markdown
Contributor

@rafaelss95,
I think this package https://github.com/okonet/lint-staged would be great too for running linters on git staged files.

And it seems to me https://github.com/semantic-release/semantic-release are better than https://github.com/conventional-changelog/standard-version

@rafaelss95
Copy link
Copy Markdown
Collaborator Author

@loktionov129 Thanks for your suggestions.

We already use lint-staged for running tslint and prettier, however commitlint has another purpose: validate commit messages to generate a good/useful changelog.

While I do like the idea of semantic-release, I don't think it's a good idea to add it here, because not every time we accept a PR, we want to make a release.

@loktionov129
Copy link
Copy Markdown
Contributor

@rafaelss95 semantic-release makes a release only when adding the commits with feature or fix types, but he doesn't releases the commits with chore/build/ci/docs/perf/refactor/style/test types.

@rafaelss95
Copy link
Copy Markdown
Collaborator Author

Yep, I know, and also when a PR containing a breaking change is accepted. I believe we don't want this behavior here, @mgechev could you give your thoughts?

@mgechev
Copy link
Copy Markdown
Owner

mgechev commented Jun 24, 2018

Yes, let's be more explicit.

@mgechev mgechev merged commit 4dfa89c into mgechev:master Jun 24, 2018
@rafaelss95 rafaelss95 deleted the chore-add-conventional-changelog branch June 24, 2018 19:08
@mgechev mgechev added this to the Tony Hoare milestone Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants