Feat/macos terminal - #16
Merged
Merged
Conversation
Let users set terminal: macos so review and work sessions open in Terminal.app tabs. Default remains iterm.
Keep it out of go test ./... and go build; run with ZEN_E2E_MACOS=1 go test -tags e2e ./internal/macos -run TestOpenTabE2E.
imkarrer
marked this pull request as draft
August 27, 2026 18:32
do script in front window targets the selected tab (queued until zen exits), and each tab is its own AppleScript window, so a tab-count check always failed. Create the tab via Shell → New Tab, then run the command there.
…r file The previous e2e passed if touch ran in the selected tab. Compare window ids so reuse of the current session fails.
imkarrer
marked this pull request as ready for review
August 27, 2026 18:59
Contributor
Author
|
@mgreau found a small issue with opening tabs when using this from my fork. To do a proper zen review you will need to refresh the worktree and context manually. Sorry for opening that permaturely. #18 Loving the tool so far. |
mgreau
self-requested a review
August 28, 2026 14:32
mgreau
added a commit
that referenced
this pull request
Aug 28, 2026
…cher * origin/main: Feat/macos terminal (#16) # Conflicts: # docs/architecture.md # docs/configuration.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zen already supports iTerm2 and Ghostty on macOS, but both are extra installs. Users who stay on Terminal.app had no way to open review/work tabs without switching emulators. This is the same backend abstraction as kitty: a small AppleScript wrapper behind
terminal: macos.Notes
ZEN_MACOS_CMDenv var so AppleScript does not have to escape the command string.iterm,ghostty,kitty, ormacos.go test ./...):ZEN_E2E_MACOS=1 go test -tags e2e ./internal/macos -run TestOpenTabE2E. Needs Automation permission for osascript → Terminal.Test plan
zen setupacceptsmacosand writesterminal: macosto configitermterminal: macos,zen review/zen work newopen a Terminal.app tab in the worktree and run the agentiterm/ghostty/kittyconfigs are unchanged