refactor(gui): share clipboard, geometry, and tree visibility helpers - #10
Merged
Merged
Conversation
Centralize terminal/composer paste normalization in ui_clipboard, scrollbar hit-testing and pixel_rect_json in ui_geometry, and collapsed-tree filtering in tab_tree. Unix sidebar rows align to shared TAB_HEIGHT (36px) matching Windows tree geometry. Co-authored-by: datakk <mgttt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates duplicated Win/Unix GUI helpers into shared modules while aligning Unix sidebar row geometry with Windows.
Changes
ui_clipboard: sharednormalize_terminal_paste,normalize_composer_paste, and paste byte limit (used by Unix GUI + remote Win32 client).ui_geometry: sharedpixel_rect_json, scrollbar hit-testing, terminal cell mapping, and wheel delta helpers (Unix input path; Win snapshot JSON).tab_tree::visible_tree_rows: shared collapsed-ancestor filtering for sidebar snapshots.TAB_HEIGHT) to match shared tree geometry andui-snapshotbounds.Validation
cargo fmtcargo clippy --target x86_64-unknown-linux-gnu --bin agenterm --bin agenterm-cli -- -D warningscargo clippy --target x86_64-pc-windows-msvc --all-targets -- -D warningscargo test --lib(243 passed)Follow-ups (not in this PR)
terminal_selectionpainting on Unix