feat(unix-gui): align sidebar scroll with Win client - #13
Merged
Conversation
Add shared sidebar scrollbar geometry helpers in ui_geometry. Unix GUI tracks sidebar_scroll_offset, wheel scrolling in the tree area, scrollbar click/drag, and emits layout.sidebar.scrollbar in ui-snapshot. Render sidebar scrollbar alongside tree rows. Co-authored-by: datakk <mgttt@users.noreply.github.com>
Co-authored-by: datakk <mgttt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Unix embedded GUI sidebar scrolling with the Windows
remote_win_appbehavior:ui_geometryhelpers for sidebar scrollbar track, row capacity, tree row geometry with scrollbar column, and scrollbar thumb geometrysidebar_scroll_offsetwith wheel scrolling when the pointer is over the sidebar treelayout.sidebar.scrollbarpopulated inui-snapshotinstead ofnullunix_app/renderValidation
cargo fmtcargo clippy --target x86_64-unknown-linux-gnu --bin agenterm --bin agenterm-cli -- -D warningscargo clippy --target x86_64-pc-windows-msvc --all-targets -- -D warningscargo test --lib(247 passed)Updates
plan/plan-unix-gui-win-parity.mdP1 sidebar scroll item to done.