feat(unix-gui): inline sidebar tab editor without Composer hijack - #14
Merged
Conversation
Unix embedded GUI now edits tab name/note inline in the sidebar tree with dedicated drafts, name/note focus, keyboard input, Save/Cancel hit targets, and ui-snapshot tab_editor.focus alignment. Composer is no longer borrowed for tab editing; set-composer routes to drafts only when the inline editor is open. Co-authored-by: datakk <mgttt@users.noreply.github.com>
Co-authored-by: datakk <mgttt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Unix embedded GUI inline tab editing with Windows
remote_win_app:tab_name_draft/tab_note_draftwithTabEditorFocus(name/note) — no Composer borrowingtext_field_key_action; Enter advances name→note or savesui-snapshottab_editor.focusreports"name"or"note"set-composerupdates drafts only when inline editor is open on that tabsidebar_tree_row_geometryfor scrollbar-column alignmentValidation
cargo fmtcargo clippy --target x86_64-unknown-linux-gnu --bin agenterm --bin agenterm-cli -- -D warningscargo clippy --target x86_64-pc-windows-msvc --all-targets -- -D warningscargo test --lib(247 passed)Updates
plan/plan-unix-gui-win-parity.mdP1 inline tab edit item to done.