chore(dogfood): Verify breaking finding via users.id PK drop#109
Closed
mhiro2 wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
Caution 🛑 Blocking findings detected. Resolve them before merging. Schema review1 breaking · 0 caution · 0 warning · 0 info Breaking
|
Replace the primary key on users (id) with a plain NOT NULL constraint so that the dogfood-review workflow surfaces a `risk/drop-pk-or-unique` breaking finding on this PR. Both posts.author_id and comments.author_id still reference users.id, which is exactly what the rule is meant to flag. This commit is the live verification of the review GitHub Action — it is not a real schema change. The PR will be reverted or kept open for inspection rather than merged.
mhiro2
force-pushed
the
chore/dogfood-schema-breaking-change
branch
from
April 29, 2026 04:03
d544ced to
fd5063b
Compare
Code Metrics Report
Details | | main (87c2b43) | #109 (f808c21) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 94.6% | 94.6% | 0.0% |
| Files | 81 | 81 | 0 |
| Lines | 36827 | 36827 | 0 |
| Covered | 34864 | 34864 | 0 |
- | Test Execution Time | 1m28s | 1m32s | +4s |Reported by octocov |
Owner
Author
|
Verified end-to-end behavior of the review GitHub Action via the dogfood Confirmed on the rebased run (after #110 landed):
Phase 2 completion criteria are now fully satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mhiro2/relune/actionreview path: introduces a deliberately breaking change todogfood/schema.sqlso that the dogfood-review workflow surfaces a blocking finding on this PR's sticky comment.Changes
id BIGINT PRIMARY KEYwithid BIGINT NOT NULLon theuserstable while leavingposts.author_idandcomments.author_idforeign keys pointing atusers (id).risk/drop-pk-or-unique(breaking) finding because the rule fires when a primary key is dropped while existing foreign keys still reference the table.