Skip to content

chore(dogfood): Verify breaking finding via users.id PK drop#109

Closed
mhiro2 wants to merge 1 commit into
mainfrom
chore/dogfood-schema-breaking-change
Closed

chore(dogfood): Verify breaking finding via users.id PK drop#109
mhiro2 wants to merge 1 commit into
mainfrom
chore/dogfood-schema-breaking-change

Conversation

@mhiro2

@mhiro2 mhiro2 commented Apr 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Live verification PR for the mhiro2/relune/action review path: introduces a deliberately breaking change to dogfood/schema.sql so that the dogfood-review workflow surfaces a blocking finding on this PR's sticky comment.
  • Not intended for merge — kept open for inspection of the rendered Markdown report. Once the comment is verified, the PR can be closed without merging.

Changes

  • d544ced : chore(dogfood): drop users.id primary key to verify breaking finding
    • Replace id BIGINT PRIMARY KEY with id BIGINT NOT NULL on the users table while leaving posts.author_id and comments.author_id foreign keys pointing at users (id).
    • The diff produces a single risk/drop-pk-or-unique (breaking) finding because the rule fires when a primary key is dropped while existing foreign keys still reference the table.

@mhiro2 mhiro2 self-assigned this Apr 29, 2026
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

Caution

🛑 Blocking findings detected. Resolve them before merging.

Schema review

1 breaking · 0 caution · 0 warning · 0 info

Breaking

  • risk/drop-pk-or-uniqueusers.id
    Primary key on users (id) is being dropped while FK posts_author_id_fkey on posts still references it. Migration will fail.
    mitigation: Drop or repoint the referencing FKs in the same migration.

Replace the primary key on users (id) with a plain NOT NULL constraint so
that the dogfood-review workflow surfaces a `risk/drop-pk-or-unique`
breaking finding on this PR. Both posts.author_id and comments.author_id
still reference users.id, which is exactly what the rule is meant to flag.

This commit is the live verification of the review GitHub Action — it is
not a real schema change. The PR will be reverted or kept open for
inspection rather than merged.
@mhiro2
mhiro2 force-pushed the chore/dogfood-schema-breaking-change branch from d544ced to fd5063b Compare April 29, 2026 04:03
@github-actions

Copy link
Copy Markdown

Code Metrics Report

main (87c2b43) #109 (f808c21) +/-
Coverage 94.6% 94.6% 0.0%
Test Execution Time 1m28s 1m32s +4s
Details
  |                     | main (87c2b43) | #109 (f808c21) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          94.6% |          94.6% | 0.0% |
  |   Files             |             81 |             81 |    0 |
  |   Lines             |          36827 |          36827 |    0 |
  |   Covered           |          34864 |          34864 |    0 |
- | Test Execution Time |          1m28s |          1m32s |  +4s |

Reported by octocov

@mhiro2

mhiro2 commented Apr 29, 2026

Copy link
Copy Markdown
Owner Author

Verified end-to-end behavior of the review GitHub Action via the dogfood
workflow on this PR — closing without merge as planned.

Confirmed on the rebased run (after #110 landed):

  • The dogfood-review workflow runs on pull_request and posts a sticky
    comment keyed on <!-- relune-dogfood-review -->.
  • A risk/drop-pk-or-unique breaking finding (PK drop with referencing
    FKs) is detected and rendered via format_review_markdown inside the
    comment body.
  • The new [!CAUTION] alert envelope (🛑 leading emoji, "Resolve them
    before merging." call-to-action) renders as expected.
  • The Fail when blocking step exits 1 so the workflow run reports
    failure once the comment is posted.
  • The earlier [!TIP] (no findings) state was confirmed on chore(action): Polish review sticky comment with alerts and emoji #110 itself,
    so all three lifecycle paths now have live coverage.

Phase 2 completion criteria are now fully satisfied.

@mhiro2 mhiro2 closed this Apr 29, 2026
@mhiro2
mhiro2 deleted the chore/dogfood-schema-breaking-change branch April 29, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant