ci(action): Cover lock-risk caution path and document dialect input#128
Merged
Conversation
Surface in both action/review.sh comments and action/README.md that the dialect input now controls more than just the SQL parser — passing postgres or mysql in review mode activates the lock-risk caution rules. Adds a dedicated Lock-risk findings section to the README that points users at deny: caution, except-rules, and per-rule severity_overrides when they want to gate the merge or tame the noise.
Adds a review smoke step that runs the action against the add-index-on-large-table fixture with dialect: postgres so the new lock-risk caution rules stay wired through the action. Asserts has-findings=true, has-blocking-findings=false (caution sits below the default deny: breaking gate), and summary-caution >= 1.
Code Metrics Report
Details | | main (1f72f53) | #128 (69c2b4e) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 94.7% | 94.7% | 0.0% |
| Files | 81 | 81 | 0 |
| Lines | 38211 | 38211 | 0 |
| Covered | 36207 | 36207 | 0 |
+ | Test Execution Time | 1m35s | 1m24s | -11s |Reported by octocov |
Schema reviewTip ✅ No risk findings — schema changes look safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dialectinput now drives both the SQL parser and the lock-risk rule evaluation inmode: review, and add a dedicated "Lock-risk findings" section toaction/README.mdpointing users atdeny: caution,except-rules, and per-ruleseverity_overrides.test-action.yamlthat runs the action againstfixtures/review/lock-risk/add-index-on-large-table-postgreswithdialect: postgresand assertssummary-caution >= 1, locking the lock-risk wiring through the action.Changes
DIALECTcomment block inaction/review.shto call out the parser + lock-risk evaluation rolesdialectinput row inaction/README.mdand add a "Lock-risk findings" section covering activation, the caution band, and the noise-tuning escape hatchesdialect: postgresagainst the add-index lock-risk fixturehas-findings=true,has-blocking-findings=false(caution stays below the defaultdeny: breakinggate), andsummary-caution >= 1