Skip to content

ci(action): Cover lock-risk caution path and document dialect input#128

Merged
mhiro2 merged 2 commits into
mainfrom
ci/action-lock-risk-smoke
May 1, 2026
Merged

ci(action): Cover lock-risk caution path and document dialect input#128
mhiro2 merged 2 commits into
mainfrom
ci/action-lock-risk-smoke

Conversation

@mhiro2

@mhiro2 mhiro2 commented May 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Document that the dialect input now drives both the SQL parser and the lock-risk rule evaluation in mode: review, and add a dedicated "Lock-risk findings" section to action/README.md pointing users at deny: caution, except-rules, and per-rule severity_overrides.
  • Add a workflow step to test-action.yaml that runs the action against fixtures/review/lock-risk/add-index-on-large-table-postgres with dialect: postgres and asserts summary-caution >= 1, locking the lock-risk wiring through the action.

Changes

  • 9b31acd : docs(action): note dialect drives lock-risk rule evaluation
    • Update the DIALECT comment block in action/review.sh to call out the parser + lock-risk evaluation roles
    • Refresh the dialect input row in action/README.md and add a "Lock-risk findings" section covering activation, the caution band, and the noise-tuning escape hatches
  • adea681 : ci(action): cover lock-risk caution path with dialect input
    • Add a review smoke step that exercises the action with dialect: postgres against the add-index lock-risk fixture
    • Assert has-findings=true, has-blocking-findings=false (caution stays below the default deny: breaking gate), and summary-caution >= 1

mhiro2 added 2 commits May 2, 2026 08:32
Surface in both action/review.sh comments and action/README.md that the
dialect input now controls more than just the SQL parser — passing
postgres or mysql in review mode activates the lock-risk caution rules.
Adds a dedicated Lock-risk findings section to the README that points
users at deny: caution, except-rules, and per-rule severity_overrides
when they want to gate the merge or tame the noise.
Adds a review smoke step that runs the action against the
add-index-on-large-table fixture with dialect: postgres so the new
lock-risk caution rules stay wired through the action. Asserts
has-findings=true, has-blocking-findings=false (caution sits below the
default deny: breaking gate), and summary-caution >= 1.
@mhiro2 mhiro2 self-assigned this May 1, 2026
@mhiro2 mhiro2 added the documentation Improvements or additions to documentation label May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Code Metrics Report

main (1f72f53) #128 (69c2b4e) +/-
Coverage 94.7% 94.7% 0.0%
Test Execution Time 1m35s 1m24s -11s
Details
  |                     | main (1f72f53) | #128 (69c2b4e) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          94.7% |          94.7% | 0.0% |
  |   Files             |             81 |             81 |    0 |
  |   Lines             |          38211 |          38211 |    0 |
  |   Covered           |          36207 |          36207 |    0 |
+ | Test Execution Time |          1m35s |          1m24s | -11s |

Reported by octocov

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Schema review

Tip

✅ No risk findings — schema changes look safe to merge.

@mhiro2
mhiro2 merged commit 9b48a53 into main May 1, 2026
6 checks passed
@mhiro2
mhiro2 deleted the ci/action-lock-risk-smoke branch May 1, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant