fix(ci): Pin Zig to 0.15.x for release builds#90
Merged
Conversation
Homebrew now ships Zig 0.16.0, which breaks cargo-zigbuild's ar wrapper when building ring and psm for the linux-musl targets. The release job was failing with "ar: error: unable to open ... libpsm_s.a" / "libring_core_*.a". Switch to the keg-only zig@0.15 formula and prepend its bin to PATH until the upstream Zig regression is fixed. Refs: rust-cross/cargo-zigbuild#433
Code Metrics Report
Details | | main (79c104e) | #90 (83ef065) | +/- |
|---------------------|----------------|---------------|------|
| Coverage | 94.7% | 94.7% | 0.0% |
| Files | 77 | 77 | 0 |
| Lines | 34529 | 34529 | 0 |
| Covered | 32726 | 32726 | 0 |
+ | Test Execution Time | 1m32s | 1m30s | -2s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zig@0.15formula in the release workflow so cargo-zigbuild can keep buildingringandpsmfor the linux-musl targets.brew install zigstarted installing 0.16.0, which breaks cargo-zigbuild'sarwrapper (zig 0.16.0 failed to build ring rust-cross/cargo-zigbuild#433). The fix is to stay on 0.15.x until the upstream Zig regression is resolved.Changes
brew install zigwithbrew install zig@0.15and prepend$(brew --prefix zig@0.15)/binto$GITHUB_PATH, since the versioned formula is keg-only.