chore(deps): update golang.org/x/exp digest to 746e56f#973
Merged
Conversation
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
cpcloud
added a commit
that referenced
this pull request
Apr 23, 2026
Two fixes tied to PR #974, where `update-vendor-hash.yml` committed `sha256-AAAAAAAAAAAA...=` to `nix/package.nix`. ## What went wrong Renovate opened #974 to major-bump `github.com/openai/openai-go` (indirect). Nothing in the repo imports `openai-go/v3` — `go mod why github.com/openai/openai-go/v3` reports `(main module does not need package ...)` — so `go mod tidy` in the vendor-hash workflow removes it. The vendor contents then match the pre-PR state, so `new_hash == old_hash`. The compute step writes the fake sentinel first, runs `nix build`, parses `got: sha256-...`, then — on the `old_hash == new_hash` branch — exits before the final `sed` that restores the real hash. `go mod tidy` still left `go.mod`/`go.sum` changes, so `git diff --cached` wasn't empty, and `Commit and push` ran with the fake hash still in `nix/package.nix`. `Verify build` was gated on `changed == 'true'` so it was skipped. See run [24829437487](https://github.com/micasa-dev/micasa/actions/runs/24829437487): `vendorHash unchanged (sha256-wDz1EKWKPkubV8NcBGQnLnRi4XT0rCjOQBKtO/yRdds=), nothing to do` immediately followed by `[renovate/major-go-indirect ee7cceb] chore: update vendorHash for Go dependency changes`. ## Changes - `.github/workflows/update-vendor-hash.yml` — move the restoration `sed` ahead of the unchanged-check, so the file always holds a real hash before any exit. Pipe `grep` through `head -n1` as a defense against multi-line output. - `renovate.json` — set `separateMajorMinor`, `separateMultipleMajor`, and `separateMinorPatch` to `false` on the `go-indirect` rule so every indirect update lands in one PR regardless of semver level. ## Reproduction 1. Open a Renovate PR that bumps only an unused indirect dep (e.g. `openai-go` v1 → v3). 2. `update-vendor-hash.yml` fires on the push. 3. `go mod tidy` removes the unused dep; vendor contents unchanged. 4. Before the fix: fake hash is committed. After the fix: the real hash is restored and only `go.mod`/`go.sum` (if tidied) end up in the commit. ## Follow-up PR #974 still has the fake-hash commit in its branch history and now conflicts on `nix/package.nix` with #973's legitimate vendorHash update. Once this merges, close #974 — Renovate will open a replacement under the new batched config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3dfff04→746e56fConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.