Skip to content

Conversation

@E5ten
Copy link
Contributor

@E5ten E5ten commented Mar 4, 2020

This seems to work correctly but probably has some inadvertent issues I'll need to fix.
EDIT: not noticing any problems, so removing WIP from the title.

@E5ten E5ten changed the title WIP: print status after job like ninja, instead of before print status after job like ninja, instead of before Mar 5, 2020
@E5ten
Copy link
Contributor Author

E5ten commented Mar 11, 2020

ping?

@michaelforney
Copy link
Owner

Sorry for the delay.

Looking more closely at ninja's code, I think it might actually be more complicated than that:

  • If the job uses the console, or the terminal is smart, the status is printed before the job.
  • Otherwise, the status is printed after the job, but in the status calculation, %r counts the newly finished job as a running job.

I don't quite remember the reason we were looking into this. Something about a missing or extra newline in the output? If that's the case, then perhaps it is not related to this after all (since with a smart terminal, ninja prints the status before the job runs, like samurai).

@E5ten
Copy link
Contributor Author

E5ten commented Mar 14, 2020

Can you tell me a range of line numbers and a file from ninja's codebase to look at where this happens? (not sure what to do until I properly get what ninja's doing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants