Make prohibited_domain_characters_regex changeable#157
Merged
micke merged 2 commits intomicke:masterfrom Aug 7, 2020
Lichtbit:make_prohibited_chars_changeable
Merged
Make prohibited_domain_characters_regex changeable#157micke merged 2 commits intomicke:masterfrom Lichtbit:make_prohibited_chars_changeable
micke merged 2 commits intomicke:masterfrom
Lichtbit:make_prohibited_chars_changeable
Conversation
On some SMTP servers you are not allowed to send mails to UTF-8 addresses. On my side its not allowed to have "umlaut" in domain part. This patch allows you to change the prohibited_domain_characters_regex such as a initalizer: ```ruby ValidEmail2::Address.prohibited_domain_characters_regex = /[+!_\/\s'`äöüÖÄÜß]/ ```
micke
requested changes
Aug 6, 2020
Owner
micke
left a comment
micke
left a comment
There was a problem hiding this comment.
Hi again, sorry for the delay and thanks for yet another good PR! I've only got one comment to make it a bit more idiomatic :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some SMTP servers you are not allowed to send mails to UTF-8 addresses. On my side its not allowed
to have "umlaut" in domain part.
This patch allows you to change the prohibited_domain_characters_regex such as a initalizer: