Add 130k more disposable domains#196
Merged
micke merged 1 commit intomicke:masterfrom Aug 20, 2022
ilyazub:feat/100k-more-disposable-domains
Merged
Add 130k more disposable domains#196micke merged 1 commit intomicke:masterfrom ilyazub:feat/100k-more-disposable-domains
micke merged 1 commit intomicke:masterfrom
ilyazub:feat/100k-more-disposable-domains
Conversation
Most probably, this commit won't be included to the upstream repo. They seem to [not accept changes to the blacklist] and closing PRs with updates to the list. Commands to update the config curl -s https://raw.githubusercontent.com/disposable/disposable-email-domains/master/domains.txt >> config/disposable_email_domains.txt sort config/disposable_email_domains.txt -u -o config/disposable_email_domains_uniq.txt mv config/disposable_email_domains_uniq.txt config/disposable_email_domains.txt [1]: #34 (comment)
Owner
|
Hello Ilya. So sorry for not attending to your PR earlier. 🇺🇦 Slava Ukraini! 🇺🇦 |
Owner
|
I've released version 4.0.4 to rubygems! |
Contributor
Author
|
Thanks, @micke! I really haven't expected you'll merge this PR due to the number of domains being added. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most probably, this PR will be rejected. For now, we use
config/blacklisted_email_domains.ymlconfig.Some disposable domains are not marked as disposable. Here's the sample.
I've merged 130k domains from the disposable repo.
Commands to update the config
$ curl -s https://raw.githubusercontent.com/disposable/disposable-email-domains/master/domains.txt >> config/disposable_email_domains.txt $ sort config/disposable_email_domains.txt -u -o config/disposable_email_domains_uniq.txt $ mv config/disposable_email_domains_uniq.txt config/disposable_email_domains.txt