Skip to content

custom cmake target: idf.py clean-ros#105

Merged
pablogs9 merged 3 commits intogalacticfrom
feature/clean-ros-target
Oct 28, 2021
Merged

custom cmake target: idf.py clean-ros#105
pablogs9 merged 3 commits intogalacticfrom
feature/clean-ros-target

Conversation

@donRaphaco
Copy link
Copy Markdown
Contributor

adds the custom CMake target clean-ros it's just a shortcut for running make -f libmicroros.mk clean.
You can just run idf.py clean-ros in the project's main directory and don't have to change directories.

@donRaphaco donRaphaco requested a review from pablogs9 October 27, 2021 09:19
@pablogs9
Copy link
Copy Markdown
Member

Awesome, thanks a lot!

@pablogs9
Copy link
Copy Markdown
Member

@mergify backport main foxy

@pablogs9 pablogs9 requested a review from Acuadros95 October 27, 2021 09:26
@pablogs9
Copy link
Copy Markdown
Member

Maybe clean-microros? thought @donRaphaco @Acuadros95?

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 27, 2021

backport main foxy

🟠 Waiting for conditions to match

Details
  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@donRaphaco
Copy link
Copy Markdown
Contributor Author

Maybe clean-microros? thought @donRaphaco @Acuadros95?

agreed 👍

@donRaphaco
Copy link
Copy Markdown
Contributor Author

Ok that's weird I could create this new branch, but I now when I try to push I get "permission denied".
@pablogs9 I think you have to do the change.

@pablogs9
Copy link
Copy Markdown
Member

Try again please

Comment thread README.md Outdated
Comment thread CMakeLists.txt Outdated
@donRaphaco
Copy link
Copy Markdown
Contributor Author

donRaphaco commented Oct 27, 2021

Try again please

@pablogs9 still the same problem. I also don't have the option to apply the suggested changes from @Acuadros95

@Acuadros95
Copy link
Copy Markdown
Contributor

No problem

@pablogs9 pablogs9 requested a review from Acuadros95 October 28, 2021 05:25
@pablogs9 pablogs9 merged commit df431ce into galactic Oct 28, 2021
@pablogs9 pablogs9 deleted the feature/clean-ros-target branch October 28, 2021 05:51
mergify Bot pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)
mergify Bot pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 28, 2021

backport main foxy

✅ Backports have been created

Details

pablogs9 pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)

Co-authored-by: donRaphaco <fixed-term.Raphael.Vogelgsang@de.bosch.com>
pablogs9 pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)

Co-authored-by: donRaphaco <fixed-term.Raphael.Vogelgsang@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants