Skip to content

Fixed build when PATH contains spaces (backport #140)#142

Merged
pablogs9 merged 1 commit intogalacticfrom
mergify/bp/galactic/pr-140
Apr 4, 2022
Merged

Fixed build when PATH contains spaces (backport #140)#142
pablogs9 merged 1 commit intogalacticfrom
mergify/bp/galactic/pr-140

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Apr 4, 2022

This is an automatic backport of pull request #140 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@RussellJoyce
Fixed build when PATH contains spaces (#140)
475e90b 
Fixes issue introduced in #63 - if PATH contains spaces (or special characters) when this line of the Makefile runs, it will corrupt the PATH variable and the build will fail.
Putting quotes around the result of the string substitution fixes this.

(cherry picked from commit 1f7e3b5)
@mergify mergify Bot mentioned this pull request Apr 4, 2022
Merged
@pablogs9 pablogs9 merged commit d35e03b into galactic Apr 4, 2022
@pablogs9 pablogs9 deleted the mergify/bp/galactic/pr-140 branch April 4, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogs9 @RussellJoyce