Fixed build when PATH contains spaces#140
Merged
pablogs9 merged 1 commit intomicro-ROS:mainfrom Apr 4, 2022
Merged
Conversation
Fixes issue introduced in micro-ROS#63 - if PATH contains spaces (or special characters) when this line of the Makefile runs, it will corrupt the PATH variable and the build will fail. Putting quotes around the result of the string substitution fixes this.
Member
|
@mergify backport foxy galactic |
Contributor
✅ Backports have been createdDetails
Hey, I reacted but my real name is @Mergifyio |
pablogs9
pushed a commit
that referenced
this pull request
Apr 4, 2022
Fixes issue introduced in #63 - if PATH contains spaces (or special characters) when this line of the Makefile runs, it will corrupt the PATH variable and the build will fail. Putting quotes around the result of the string substitution fixes this. (cherry picked from commit 1f7e3b5) Co-authored-by: Russell Joyce <russell@russellj.co.uk>
pablogs9
pushed a commit
that referenced
this pull request
Apr 4, 2022
Fixes issue introduced in #63 - if PATH contains spaces (or special characters) when this line of the Makefile runs, it will corrupt the PATH variable and the build will fail. Putting quotes around the result of the string substitution fixes this. (cherry picked from commit 1f7e3b5) Co-authored-by: Russell Joyce <russell@russellj.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced in #63 - if PATH contains spaces (or special characters) when this line of the Makefile runs, it will corrupt the PATH variable and the build will fail.
Putting quotes around the result of the string substitution fixes this.