Update dockerfile baseimage#87
Merged
pablogs9 merged 2 commits intomicro-ROS:galacticfrom Aug 26, 2021
Merged
Conversation
pablogs9
approved these changes
Aug 26, 2021
Member
|
@mergify backport main |
Member
|
@gustavo-oliveira-mendonca Thanks a lot for the contribution! |
Contributor
|
Command
Hey, I reacted but my real name is @Mergifyio |
mergify Bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Update baseimage to espressif/idf:release-v4.3 * Adding missing python dep importlib-resources Co-authored-by: Gustavo O. Mendonça <gustavo.mendonca@ihm.com.br> (cherry picked from commit ac1ede4)
Contributor
|
Command
|
pablogs9
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Update baseimage to espressif/idf:release-v4.3 * Adding missing python dep importlib-resources Co-authored-by: Gustavo O. Mendonça <gustavo.mendonca@ihm.com.br> (cherry picked from commit ac1ede4) Co-authored-by: Gustavo Oliveira Mendonça <gustavo36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't correctly configure the esp-idf toolchain on my machine and I was very happy to know that there was the possibility of using Docker for the build, upload and monitor processes. I wasn't successful with the current Dockerfile, but updating the base image to version 4.3 of the toolchain and adding a missing dependency fixed the issues.