Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Feature/cmake options#1

Merged
pablogs9 merged 4 commits intogalacticfrom
feature/cmake_options
Oct 11, 2021
Merged

Feature/cmake options#1
pablogs9 merged 4 commits intogalacticfrom
feature/cmake_options

Conversation

@Acuadros95
Copy link
Copy Markdown
Contributor

@Acuadros95 Acuadros95 commented Oct 8, 2021

TODO: Apply this configuration to embeddedRTPS config files (example)

Comment thread CMakeLists.txt
set(RMW_ERTPS_MAX_INPUT_BUFFER_SIZE "1000" CACHE STRING "TODO")
set(RMW_ERTPS_MAX_OUTPUT_BUFFER_SIZE "1000" CACHE STRING "TODO")

set(RMW_ERTPS_MAX_SESSIONS "1" CACHE STRING "This value sets the maximum number of embeddedRTPS sessions.")
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the session concept still apply?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we should review which parameters apply

@Acuadros95 Acuadros95 requested a review from pablogs9 October 8, 2021 12:06
@pablogs9 pablogs9 merged commit 877bfe6 into galactic Oct 11, 2021
@pablogs9 pablogs9 deleted the feature/cmake_options branch October 11, 2021 05:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants