Fail agent-flow on missing onboarding side effects#4334
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR strengthens the internal/harness/agent-flow harness by making it explicitly wait for required onboarding side effects (workspace creation + notification send) and fail the harness run if those side effects don’t occur within the deadline, preventing “successful” conformance runs with missing behavior.
Changes:
- Added
waitForOnboardingSideEffectspolling helper with timeout-based failure. - Updated the harness main flow to exit non-zero when required side effects are missing.
- Added unit tests covering both missing and completed side-effect cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/harness/agent-flow/main.go | Adds side-effect waiting helper and makes the harness fail (exit 1) when onboarding side effects are missing. |
| internal/harness/agent-flow/main_test.go | Adds focused tests for the new side-effect waiting helper (missing vs complete). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+191
to
+195
| select { | ||
| case <-ctx.Done(): | ||
| return fmt.Errorf("agent-flow missing required onboarding side effects before timeout: workspaces=%d/1 notifications=%d/1", workspaces, notifications) | ||
| case <-ticker.C: | ||
| } |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Testing:
Closes #4328
Closes #4333