Migrate postgres pgx store to pgx v5#4736
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the Postgres store/postgres/pgx implementation from github.com/jackc/pgx/v4 to github.com/jackc/pgx/v5, aligning dependencies with the v5 line to address the reachable-vulnerability findings described in #4556.
Changes:
- Updated
store/postgres/pgximports frompgx/v4topgx/v5. - Switched pool construction to the v5 API (
pgxpool.NewWithConfig). - Updated module requirements to depend on
pgx/v5and refreshed related sums.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| store/postgres/pgx/pgx.go | Migrates pgx imports to v5 and updates pgxpool construction API. |
| store/postgres/pgx/db.go | Updates pgxpool import to v5. |
| go.mod | Replaces pgx/v4 requirement with pgx/v5 and updates indirect deps accordingly. |
| go.sum | Reflects dependency graph changes from pgx v4 → v5 migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+134
to
137
| db, err := pgxpool.NewWithConfig(s.options.Context, config) | ||
| if err != nil { | ||
| return err | ||
| } |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4556
Closes #4735
Testing