Skip to content

Make x402 identity follow the public resource #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asim merged 1 commit into from
Sep 4, 2026
+11 −10
Merged

Make x402 identity follow the public resource #1491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions internal/x402/x402.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,7 @@ func WritePaymentRequired(w http.ResponseWriter, operation, resource string, ext
return false
}
if reason == "" {
reason = "This tool costs credits. Sign in, or send a token from /token as " +
"'Authorization: Bearer' — see /tools. Machine callers can pay per call " +
"with an X-PAYMENT header instead; see accepts."
reason = "Payment required. Choose an entry from accepts, submit payment, and retry."

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve account access guidance on the Mu endpoint

When an anonymous or invalid-token caller reaches a metered /mcp operation on the normal Mu surface, payer supplies an empty reason, so this becomes the only guidance returned and removes the existing sign-in/Bearer-token alternatives for callers who do not want to make an x402 payment. Because the same function serves both the alternate M3O surface and the regular Mu endpoint, this also deterministically breaks TestAChallengeSaysWhyThisCallerWasRefused in internal/x402/reason_test.go; select the protocol-only wording for the alternate surface without deleting the standard Mu access paths.

Useful? React with 👍 / 👎.

}
body := map[string]any{
"x402Version": x402Ver(),
Expand All @@ -340,7 +338,7 @@ func WritePaymentRequired(w http.ResponseWriter, operation, resource string, ext
"url": resource,
"description": "Access to " + operation,
"mimeType": "application/json",
"serviceName": serviceName(),
"serviceName": serviceName(resource),
"tags": []string{"mcp", "agent-tools"},
}
}
Expand Down Expand Up @@ -866,12 +864,15 @@ func PayerFrom(ctx context.Context) string {

// serviceName is what this instance calls itself in a discovery listing.
//
// The index shows a name rather than a URL, so without one an entry is a bare
// address next to entries that read like products. Derived from the mail domain
// or the public URL rather than configured separately: an operator has already
// said what this instance is called, and asking twice invites the two to
// disagree.
func serviceName() string {
// The public resource is the authoritative identity for a request. That matters
// when one Mu instance is exposed through more than one public surface: the
// x402 challenge should name the host the caller is actually paying, not leak
// the instance's configured mail/application domain. Configuration remains the
// fallback for callers that provide a non-URL resource.
func serviceName(resource string) string {
if u, err := url.Parse(strings.TrimSpace(resource)); err == nil && u.Host != "" {
return u.Host
}
if u := strings.TrimSpace(settings.Get("MU_DOMAIN")); u != "" {
return u
}
Expand Down
Loading