Change unifrac implementation from rbiom to ecodive #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antagomir
approved these changes
Dec 7, 2025
Member
|
Sorry for delays. This had escaped my attention. Looks very good. Can we merge, or does @TuomasBorman have any final remarks? @RiboRings could we use this for updated benchmarks in OMA paper..? |
Member
|
Sure! I will wait for this to be merged. |
Member
Oke - @RiboRings way to go! |
Member
|
Added here: microbiome/OMA_manuscript#75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #783, this pull request changes the old unifrac implementation from
rbiom::unifracto correspondingecodivefunctions. Based on my own testing the results are identical to the old version, and there seems to be a noticeable increase in speed as well. I think this means that #756 can be closed, as I doubt there would be anything to gain in continuing to develop our own unifrac implementation alongsideecodive's.