Merged
Conversation
Contributor
Author
|
The old and new version are now producing the same results: |
TuomasBorman
commented
Mar 3, 2026
TuomasBorman
commented
Mar 5, 2026
TuomasBorman
commented
Mar 5, 2026
Contributor
Author
|
Scripts to test that the Gemelli and our implementation is working similarly test_joint_optspace.py |
TuomasBorman
commented
Mar 12, 2026
| # Column centering (training means) | ||
| mat <- sweep(mat, 2L, center[["col"]], "-") | ||
| # Add grand mean to avoid subtracting the mean twice (training means) | ||
| # mat <- mat + center[["grand"]] |
TuomasBorman
commented
Mar 12, 2026
|
|
||
| # We multiply U by singular values so that the sample coordinates reflect | ||
| # actual variance magnitude rather than just orthonormal directions. | ||
| # u <- u %*% diag(s) |
TuomasBorman
commented
Mar 12, 2026
| mat <- sweep(mat, 2L, col_means, "-") | ||
| # Add overall mean so that we do not subtract the data effectively 2 times. | ||
| # The result is a matrix that has row and column means in zero. | ||
| # mat <- mat + grand_mean |
Contributor
Author
|
TODO:
|
TuomasBorman
commented
Mar 15, 2026
| # Row centering (new samples) | ||
| mat <- sweep(mat, 1L, rowMeans(mat), "-") | ||
| # Column centering (training means) | ||
| # mat <- sweep(mat, 2L, center[["col"]], "-") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.