Text recipe - #11
Merged
Merged
Conversation
Chakra's Text could be given sizes and a default via an app theme's
components.Text — python-editor's set a default of md, which the bare
styled("p") port lost (unsized <Text> regressed to the inherited 16px
there). A config recipe so an app preset can extend defaultVariants to
restore that. No default size here: with no size prop Text inherits,
matching Chakra's defaultless Text, which the other apps rely on (e.g.
ml-trainer's unsized Text inside Tooltip labels inheriting the
tooltip's sm).
Same treatment as the earlier story split: each component gets its own file with component metadata for per-component controls and a Playground, plus Sizes/examples carried over from the catalog. Text gains a Sizes story covering the recipe's sm/md/lg variants alongside the default inheriting behaviour.
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Aug 3, 2026
The gotcha told apps to swap Panda's AspectRatio pattern for the native property. Native aspect-ratio needs Safari 15 / iOS 15 / Firefox 89, and the family floor is 14.1 / 14.5 / 88, so on three of five targets the declaration is dropped and the box collapses to content height — no fallback, and nothing for lightningcss to downlevel. Panda's pattern is the same padding-bottom hack as Chakra's and works everywhere; classroom measured the two identical. The child-override conflict the gotcha is actually about only arises when the child is a Chakra component with its own position, so porting the child first makes the pattern safe. Flags the sites in ml-trainer and python-editor that took the old advice.
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Aug 3, 2026
…a note Gotcha #11 mentions the affected sites, but a corrected gotcha isn't where anyone looks for outstanding work on a migration that's already signed off. Adds an 'open across the completed migrations' section to the roadmap with the specific files in ml-trainer and python-editor, and is explicit that nobody has yet confirmed them visibly broken on a real Safari 14 — that check comes before any change.
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Aug 3, 2026
The gotcha told apps to swap Panda's AspectRatio pattern for the native property. Native aspect-ratio needs Safari 15 / iOS 15 / Firefox 89, and the family floor is 14.1 / 14.5 / 88, so on three of five targets the declaration is dropped and the box collapses to content height — no fallback, and nothing for lightningcss to downlevel. Panda's pattern is the same padding-bottom hack as Chakra's and works everywhere; classroom measured the two identical. The child-override conflict the gotcha is actually about only arises when the child is a Chakra component with its own position, so porting the child first makes the pattern safe. Flags the sites in ml-trainer and python-editor that took the old advice.
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Aug 3, 2026
…a note Gotcha #11 mentions the affected sites, but a corrected gotcha isn't where anyone looks for outstanding work on a migration that's already signed off. Adds an 'open across the completed migrations' section to the roadmap with the specific files in ml-trainer and python-editor, and is explicit that nobody has yet confirmed them visibly broken on a real Safari 14 — that check comes before any change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.