`APISource` importer with `repository.secretRef` fails at runtime with `The given id must not be null` (operator path)

[adrims]

Describe the bug

When creating APISource resources with spec.importers[].repository.secretRef (PAT secret provided via SecretSource), the APISource reconciles to READY, but importer execution fails at runtime with:

java.lang.IllegalArgumentException: The given id must not be null

This blocks private repository imports via importer jobs.

Expected behavior

APISource importers using repository.secretRef should create functional import jobs and import from private repos successfully (same secret already available in Microcks).

Actual behavior

Microcks, SecretSource, and APISource show READY
Importer job starts, then fails in Microcks runtime with null id error
Direct artifact download with the same secret works

How to Reproduce?

Deploy Microcks with operator.
Create a SecretSource that creates a Microcks secret with PAT credentials.
Create an APISource with importer + repository.secretRef referencing that secret.
Observe APISource status becomes READY.
Check Microcks app logs when importer runs.

From Microcks app logs:

Starting import for job 'XXX'
Servlet.service() ... java.lang.IllegalArgumentException: The given id must not be null
stack points to io.github.microcks.service.JobService.doImportJob(JobService.java:70)

Microcks version or git rev

1.14.0-RC1 & 1.14.0-RC2

Install method (docker-compose, helm chart, operator, docker-desktop extension,...)

operator

Additional information

spec.artifacts with secretRef works for the same private URL/secret (imports service/mocks).
Direct call to artifact download endpoint with same secret succeeds.
Failure seems specific to importer job path (spec.importers).

Suspected root cause
In operator importer mapping (APISourceReconciler.updateWithImporterSpec()), SecretRef.name is set from repository.secretRef, but SecretRef.secretId is not set.
At runtime, JobService.doImportJob() resolves secret by job.secretRef.secretId, causing null-id failure.

[github-actions]

👋 @adrims

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first issue here! Be sure to follow the issue template or please update it accordingly.

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Hope you have a great time there!

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

[adrims]

Maybe something like this could fix it if you add the ApiClient to updateWithImporterSpec method and get the secret ID filled:

 protected void updateWithImporterSpec(ApiClient apiClient, ImportJob job, ImporterSpec importerSpec) throws ApiException {
      job.setName(importerSpec.getName());
      job.setRepositoryUrl(importerSpec.getRepository().getUrl());
      job.setRepositoryDisableSSLValidation(importerSpec.getRepository().getDisableSSLValidation());
      job.setMainArtifact(importerSpec.getMainArtifact());
      job.setActive(importerSpec.getActive());
      if (importerSpec.getRepository().getSecretRef() != null) {
         String secretName = importerSpec.getRepository().getSecretRef();
         ConfigApi configApi = new ConfigApi(apiClient);
         List<Secret> secrets = configApi.getSecrets(0, 200);
         Secret secret = secrets.stream()
               .filter(s -> secretName.equals(s.getName()))
               .findFirst()
               .orElseThrow(() -> new ApiException("Secret '" + secretName + "' not found in Microcks"));
         SecretRef secretRef = new SecretRef();
         secretRef.setName(secretName);
         **secretRef.setSecretId(secret.getId());**
         job.setSecretRef(secretRef);
      }
      if (importerSpec.getLabels() != null) {
         Metadata metadata = new Metadata();
         metadata.setLabels(importerSpec.getLabels());
         job.setMetadata(metadata);
      }
   }

[lbroudoux]

Hi @adrims,

Thanks for opening this one and for the detailed analysis! And sorry for the bug.

You're right: it looks like the artifact upload and the job creation APIs are not homogeneous on the Microcks server side.

If we want the fix to work with all the Microcks versions, your fix suggestion seems correct. We also have a configApi.searchSecrets(secretName) API that still returns a list of secrets, but would be better to use for this.

Do you want to push a PR on this, as you already did most of the job? Or do you prefer that I do it on my side? Either way, I'll be able to merge and release quickly.

Let me know what's best for you.

[adrims]

Hey @lbroudoux , thanks for the quick response, you can deploy it, as I'll be out a few days I don't want to block you!

BR,

[adrims]

Hey @lbroudoux, I'm back, if you can give me permissions to write in the repo I can send the PR

[lbroudoux]

Hi 👋 You need to fork the repo and then issue a PR. Make sure your commits are signed with your email address, as this is a pre-requisite for CNCF projects.

[adrims]

Hi 👋 You need to fork the repo and then issue a PR. Make sure your commits are signed with your email address, as this is a pre-requisite for CNCF projects.

Here it is -> #257

[lbroudoux]

@adrims The nightly image embedding your fix is now available. Could you try it out, check it fixes your issue, and provide feedback here? I'll release it as version 0.0.9 just after. Thanks,

[adrims]

@lbroudoux Tested! works as expected, thanks for your help!