fix: set importer secretId from secretRef name#257
Conversation
|
👋 @adrims Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
|
Hey! Thanks for taking the time to push this, I was not able to do so these last days. To add your Signed-off-by line to every commit in this branch:
|
lbroudoux
left a comment
There was a problem hiding this comment.
It looks good to me. Please fix the commit signature, and I'll be able to merge.
Signed-off-by: adrims <adrims1986@gmail.com>
d8a028e to
29a9fc1
Compare
Ops, sorry I though I did it, now should be ok! |
|
🎉 @adrims You are now a Microcks community contributor! 💖 Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏 📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌" Kudos and please keep going, we need you 🙌 |
Summary
This fixes importer creation when spec.importers[].repository.secretRef is provided.
The operator was setting only[job.secretRef.name, but Microcks importer runtime expects job.secretRef.secretId in this path.
As a result, importer jobs could fail at runtime with:
java.lang.IllegalArgumentException: The given id must not be null
What changed
In APISourceReconciler.java:
During importer mapping, resolve secret by name using ConfigApi.searchSecrets(secretName).
Set both:
Why
This aligns the operator behavior with Microcks job API expectations and enables private repository importer jobs using repository.secretRef.
Related
Fixes #256