Skip to content

update version number in spec and references to spec#607

Merged
MikeEdgar merged 1 commit into
microprofile:mainfrom
benjamin-confino:606-update-version-spec
May 15, 2024
Merged

update version number in spec and references to spec#607
MikeEdgar merged 1 commit into
microprofile:mainfrom
benjamin-confino:606-update-version-spec

Conversation

@benjamin-confino

Copy link
Copy Markdown
Contributor

This resolves #606

@eclipse-microprofile-bot

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

Comment thread README.adoc Outdated
Comment thread api/src/main/java/org/eclipse/microprofile/openapi/annotations/Components.java Outdated
@Azquelt

Azquelt commented May 2, 2024

Copy link
Copy Markdown
Member

Please refer to https://spec.openapis.org/oas/v3.1.0.html for the correct name of anything and link within that document where our spec needs to link to the OpenAPI spec.

This issue is not a simple find and replace of 3.0 with 3.1.

@benjamin-confino benjamin-confino marked this pull request as draft May 3, 2024 09:18
@benjamin-confino benjamin-confino force-pushed the 606-update-version-spec branch 5 times, most recently from 38d1cf5 to 7f026ea Compare May 3, 2024 12:47
@benjamin-confino benjamin-confino marked this pull request as ready for review May 3, 2024 12:47
@benjamin-confino

Copy link
Copy Markdown
Contributor Author

If everything looks good I'll squash this down.

@Azquelt

Azquelt commented May 3, 2024

Copy link
Copy Markdown
Member

The last commit puts double-hashes in all the URLs.

Comment thread README.adoc Outdated
Comment thread tck/src/main/java/org/eclipse/microprofile/openapi/apps/airlines/JAXRSApp.java Outdated
Comment thread spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated
Comment thread spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated
Comment thread spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc

@Azquelt Azquelt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links now look good, but in many cases the link text was wrong or inconsistent (either changed accidentally in this PR, or was incorrect before).

Comment thread api/src/main/java/org/eclipse/microprofile/openapi/annotations/info/Contact.java Outdated
Comment thread api/src/main/java/org/eclipse/microprofile/openapi/annotations/info/Info.java Outdated
Comment thread api/src/main/java/org/eclipse/microprofile/openapi/models/servers/Server.java Outdated
Comment thread spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated
Comment thread spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated
Comment thread spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc
@Azquelt

Azquelt commented May 13, 2024

Copy link
Copy Markdown
Member

I have belatedly noticed that many of my suggested changes will need re-wrapped by the autoformatter.

@Azquelt Azquelt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been through and checked all of the links, this now looks good to me.

@MikeEdgar

Copy link
Copy Markdown
Contributor

@eclipse-microprofile-bot test this please

@benjamin-confino

Copy link
Copy Markdown
Contributor Author

Excellent news. Now it is time to squash this all down.

@benjamin-confino benjamin-confino force-pushed the 606-update-version-spec branch from 05a86d6 to a0068d1 Compare May 14, 2024 20:05
@MikeEdgar MikeEdgar merged commit 5db8757 into microprofile:main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OAS 3.1.0] Update spec document references

4 participants