requests: Match response header names case-insensitively. - #1147
Open
pablogventura wants to merge 1 commit into
Open
requests: Match response header names case-insensitively.#1147pablogventura wants to merge 1 commit into
pablogventura wants to merge 1 commit into
Conversation
Signed-off-by: Pablo Ventura <pablogventura@gmail.com>
dpgeorge
reviewed
Aug 11, 2026
| k, v = l.split(":", 1) | ||
| v = v.strip() | ||
| resp_d[k] = v | ||
| if k.lower() == "content-length": |
Member
There was a problem hiding this comment.
Could this line now be if lowerl.startswith(b"content-length:")? That saves a call to lower() and the associated memory overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urequestsPR; the module is nowrequests).Transfer-EncodingandLocationon the wire case-insensitively (RFC 9110 Sec. 5.1), samelowerl = l.lower()once-per-line pattern as urequests: Detect specific header field names caselessly #523 and aiohttp: Match response header names case-insensitively. #1146.requestshalf of aiohttp module case-insensitive headers #1126. aiohttp: Match response header names case-insensitively. #1146 stays aiohttp-only.Test plan
test_requests.py, including lowercasetransfer-encodingchunked andlocationredirect cases.__init__.mpy(mpy-cross, compiled as__init__.py): master 3160, this PR 3169 (+9).