extmod/modonewire.c reliable timings for onewire.#13171
Merged
dpgeorge merged 1 commit intomicropython:masterfrom Dec 15, 2023
Merged
extmod/modonewire.c reliable timings for onewire.#13171dpgeorge merged 1 commit intomicropython:masterfrom
dpgeorge merged 1 commit intomicropython:masterfrom
Conversation
|
Code size report: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13171 +/- ##
==========================================
- Coverage 98.40% 98.36% -0.04%
==========================================
Files 159 159
Lines 21075 20989 -86
==========================================
- Hits 20738 20646 -92
- Misses 337 343 +6 ☔ View full report in Codecov by Sentry. |
Member
|
See related #7050. |
When using long cables for sensors on onewire e.g. ds18b20, the current default timings are too optimistic, leading to bus failures and CRC errors. Stable results are achieved with the timings given by https://www.analog.com/en/technical-articles/1wire-communication-through-software.html
5b70c10 to
2e101a8
Compare
Member
|
I merged #7050 first, which fixed the read timings (there was a long discussion there). This PR is also merged, fixing the write timings. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using long cables for sensors on onewire e.g. ds18b20,
the current default timings might be to optimistic.
Thus leading to bus failures and CRC errors.
Timings given by https://www.analog.com/en/technical-articles/1wire-communication-through-software.html give stable results.