machine_uart.c: Call uart_wait_tx_done() only with installed driver.#18124
Merged
dpgeorge merged 1 commit intomicropython:masterfrom Sep 25, 2025
Merged
machine_uart.c: Call uart_wait_tx_done() only with installed driver.#18124dpgeorge merged 1 commit intomicropython:masterfrom
dpgeorge merged 1 commit intomicropython:masterfrom
Conversation
dpgeorge
reviewed
Sep 23, 2025
robert-hh
force-pushed
the
esp32_uart_init
branch
from
c12b170 to
c7a36cf
Compare
dpgeorge
approved these changes
Sep 24, 2025
Member
dpgeorge
left a comment
dpgeorge
left a comment
There was a problem hiding this comment.
Thanks for updating. Looks good now!
Otherwise an error message will pop up at the first instatiation of the UART object. Addresses micropython#18122 / micropython#18123. Signed-off-by: robert-hh <robert@hammelrath.com>
robert-hh
force-pushed
the
esp32_uart_init
branch
from
c7a36cf to
d0d9d97
Compare
Contributor
Author
|
The last push just fixes the commit message format error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call uart_wait_tx_done() only with installed driver. Otherwise an error message will pop up at the first instantiation of the UART object.
Addresses #18122 / #18123.
Testing
Tested with a ESP32 classic and ESP32C3. Test objective: