esp32/network_ppp: Add a timeout for closing PPP connection.#4766
Closed
dpgeorge wants to merge 1 commit intomicropython:masterfrom
Closed
esp32/network_ppp: Add a timeout for closing PPP connection.#4766dpgeorge wants to merge 1 commit intomicropython:masterfrom
dpgeorge wants to merge 1 commit intomicropython:masterfrom
Conversation
Member
Author
|
This may not be a full solution to getting PPP closing reliably but it's definitely a step in the right direction. So merged in 0557f0b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for issue #4708 .
A limitation with this: once the PPP is deactivated (ppp.active(0)) it cannot be used again. A new PPP instance must be created instead.