Skip to content

py/obj: fix spelling of truncated#5604

Closed
dlech wants to merge 1 commit intomicropython:masterfrom
dlech:spelling
Closed

py/obj: fix spelling of truncated#5604
dlech wants to merge 1 commit intomicropython:masterfrom
dlech:spelling

Conversation

@dlech
Copy link
Copy Markdown
Contributor

@dlech dlech commented Feb 3, 2020

No description provided.

@dpgeorge
Copy link
Copy Markdown
Member

dpgeorge commented Feb 4, 2020

Might I suggest instead that this entire TODO comment be removed, and instead recorded as a GitHub issue discussing this possible optimisation? On the one hand it's nice to have such comments in the code for people to discover and think about, but on the other hand it's not really sustainable to do it for all ideas. This comment was from very early on in the project.

@dpgeorge dpgeorge added the py-core Relates to py/ directory in source label Feb 4, 2020
It was suggested to move this to a GitHub issue rather than keep it
in the code.
@dlech
Copy link
Copy Markdown
Contributor Author

dlech commented Feb 13, 2020

updated

@dpgeorge
Copy link
Copy Markdown
Member

Thanks, merged in f020eac

@dpgeorge dpgeorge closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

py-core Relates to py/ directory in source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants