Revert: add web consent redirect URIs to BYO Entra apps#455
Merged
Conversation
This reverts commit 091d51d.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that appended admin consent (web platform) redirect URIs to Entra app registrations created/updated by the publish and register flows, restoring the prior behavior of only setting the canonical/public-client redirect URIs.
Changes:
- Removes consent redirect URI generation and web-redirect URI patching from the Entra app provisioning flow.
- Updates register/publish executors to stop appending consent redirect URIs during redirect URI updates.
- Deletes the related unit tests and simplifies the remaining Public Clients redirect URI tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/EntraAppProvisionerTests.cs | Removes consent redirect URI tests and updates Public Clients redirect URI assertions to match the reverted behavior. |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/EntraAppProvisioner.cs | Removes consent redirect URI logic and the web redirect URI update step during Public Clients app creation. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/RegisterCommandExecutor.cs | Stops appending consent redirect URIs and removes consent-only fallback updates during redirect URI configuration. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/PublishCommandExecutor.cs | Updates the Public Clients provisioning callsite to match the updated provisioner signature. |
gwharris7
approved these changes
Jun 12, 2026
sellakumaran
approved these changes
Jun 12, 2026
sruthikilari
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
091d51d) which added web consent redirect URIs to all Entra app registrations in the addmcpserver/publish flowsGetConsentRedirectUris,SetWebConsentRedirectUrisAsync, and consent URI appending inRegisterCommandExecutorandPublishCommandExecutorEntraAppProvisionerTestsTest plan
dotnet test tests.projpasses🤖 Generated with Claude Code