Skip to content

Revert: add web consent redirect URIs to BYO Entra apps#455

Merged
gwharris7 merged 1 commit into
mainfrom
u/bhraguru/revert-consent-redirect-uris
Jun 12, 2026
Merged

Revert: add web consent redirect URIs to BYO Entra apps#455
gwharris7 merged 1 commit into
mainfrom
u/bhraguru/revert-consent-redirect-uris

Conversation

@ragurubhaarath

Copy link
Copy Markdown
Contributor

Summary

  • Reverts PR feat: add web consent redirect URIs to BYO Entra apps #450 (091d51d) which added web consent redirect URIs to all Entra app registrations in the addmcpserver/publish flows
  • Removes GetConsentRedirectUris, SetWebConsentRedirectUrisAsync, and consent URI appending in RegisterCommandExecutor and PublishCommandExecutor
  • Removes associated tests in EntraAppProvisionerTests

Test plan

  • Verify dotnet test tests.proj passes
  • Verify register and publish flows still create apps without consent redirect URIs

🤖 Generated with Claude Code

@ragurubhaarath
ragurubhaarath requested a review from a team as a code owner June 11, 2026 23:52
Copilot AI review requested due to automatic review settings June 11, 2026 23:52
@ragurubhaarath
ragurubhaarath requested a review from a team as a code owner June 11, 2026 23:52
@github-actions

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the earlier change that appended admin consent (web platform) redirect URIs to Entra app registrations created/updated by the publish and register flows, restoring the prior behavior of only setting the canonical/public-client redirect URIs.

Changes:

  • Removes consent redirect URI generation and web-redirect URI patching from the Entra app provisioning flow.
  • Updates register/publish executors to stop appending consent redirect URIs during redirect URI updates.
  • Deletes the related unit tests and simplifies the remaining Public Clients redirect URI tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/EntraAppProvisionerTests.cs Removes consent redirect URI tests and updates Public Clients redirect URI assertions to match the reverted behavior.
src/Microsoft.Agents.A365.DevTools.Cli/Services/EntraAppProvisioner.cs Removes consent redirect URI logic and the web redirect URI update step during Public Clients app creation.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/RegisterCommandExecutor.cs Stops appending consent redirect URIs and removes consent-only fallback updates during redirect URI configuration.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/PublishCommandExecutor.cs Updates the Public Clients provisioning callsite to match the updated provisioner signature.

@gwharris7
gwharris7 merged commit a398cfc into main Jun 12, 2026
10 checks passed
@gwharris7
gwharris7 deleted the u/bhraguru/revert-consent-redirect-uris branch June 12, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants