removing tools mode - #121
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the "tools mode" feature from the codebase, which previously allowed switching between MockMCPServer and MCPPlatform modes. The change simplifies the tooling architecture by removing conditional logic that was no longer needed.
- Removed the
ToolsModeenum and associated configuration logic - Eliminated conditional behavior based on tools mode from MCP tool registration services
- Cleaned up unused utility method
GetToolsModefrom theUtilityclass
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Tooling/Extensions/SemanticKernel/Services/McpToolRegistrationService.cs | Removed unused toolsMode variable retrieval from the AddToolServersToAgentAsync method |
| src/Tooling/Extensions/AzureAIFoundry/Services/McpToolRegistrationService.cs | Removed toolsMode variable and conditional logic that skipped live validation in MockMCPServer mode |
| src/Tooling/Core/Utils/Utility.cs | Removed the GetToolsMode utility method that retrieved tools mode configuration |
| src/Tooling/Core/Models/ToolsMode.cs | Deleted the entire ToolsMode enum file that defined MockMCPServer and MCPPlatform modes |
Johan Broberg (pontemonti)
approved these changes
Dec 4, 2025
Tahir Sousa (tmlsousa)
approved these changes
Dec 4, 2025
Johan Broberg (pontemonti)
deleted the
users/anabdul/remove_tools_mode
branch
December 5, 2025 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.