Expose session Id for baggage builder - #71
Merged
Merged
Conversation
nikhilNava
requested changes
Nov 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes session ID support in the baggage builder and span processor, allowing session IDs to be propagated through OpenTelemetry context and automatically enriched into span attributes.
- Adds
sessionId()method toBaggageBuilderclass with fluent API support - Updates
setRequestContext()static method to accept an optionalsessionIdparameter - Includes
SESSION_ID_KEYin the list of generic attributes automatically copied from baggage to spans
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/agents-a365-observability/src/tracing/middleware/BaggageBuilder.ts | Adds sessionId() method and updates setRequestContext() to accept sessionId parameter |
| packages/agents-a365-observability/src/tracing/processors/util.ts | Adds SESSION_ID_KEY to GENERIC_ATTRIBUTES array for automatic span enrichment |
| tests/observability/core/BaggageBuilder.test.ts | Adds comprehensive test coverage for sessionId functionality in fluent API, static method, and empty value handling |
| tests/observability/core/SpanProcessor.test.ts | Adds test for sessionId propagation from baggage to span attributes and updates attribute registry test |
nikhilNava
requested changes
Nov 17, 2025
nikhilNava
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose session Id for baggage builder