add support for sse redirect and http proxy settings #1718
Conversation
…/track for non aad auth path
Is this what other SDKs are doing? |
synced with other sdks. If the SDK already supports Stamp Specific redirects(SSR), recommendation is to use v2.1/track. But for Python, SSR not yet supported , hence the implementation is different from Nodejs and Java. |
core/src/main/java/com/microsoft/applicationinsights/TelemetryChannel.java
Outdated
Show resolved
Hide resolved
...va/com/microsoft/applicationinsights/internal/authentication/AzureMonitorRedirectPolicy.java
Outdated
Show resolved
Hide resolved
...va/com/microsoft/applicationinsights/internal/authentication/AzureMonitorRedirectPolicy.java
Outdated
Show resolved
Hide resolved
| final HttpRequest originalHttpRequest, | ||
| final int retryCount) { | ||
| // make sure the context is not modified during retry, except for the URL | ||
| context.setHttpRequest(originalHttpRequest.copy()); |
There was a problem hiding this comment.
does this need to pass around originalHttpRequest or can it use context.getHttpRequest() each time?
There was a problem hiding this comment.
I believe we can use context.getHttpRequest, but I followed the same standard of setting the context from https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/core/azure-core/src/main/java/com/azure/core/http/policy/RetryPolicy.java#L96
…rypolicy in httppipeline
|
This pull request introduces 1 alert when merging d777285 into 5837b5a - view on LGTM.com new alerts:
|
kryalama
changed the title
|
This pull request introduces 1 alert when merging 453daac into 5837b5a - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging d749135 into 4b730d0 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging a90132a into 9219bbf - view on LGTM.com new alerts:
|
...ing/src/main/java/com/microsoft/applicationinsights/agent/internal/AiComponentInstaller.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/microsoft/applicationinsights/TelemetryChannel.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/microsoft/applicationinsights/internal/authentication/AadAuthentication.java
Outdated
Show resolved
Hide resolved
...va/com/microsoft/applicationinsights/internal/authentication/AzureMonitorRedirectPolicy.java
Outdated
Show resolved
Hide resolved
...pps/WebFlux/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java
Outdated
Show resolved
Hide resolved
...pps/WebFlux/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java
Outdated
Show resolved
Hide resolved
...ilter/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/CoreAndFilterTests.java
Show resolved
Hide resolved
@kryalama when you have a chance, also check out the lgtm alert above |
add support for sse redirect
add support for http proxy settings
use LazyAzureHttpClient in telemetry channel
Fix bug based on aad enabled flag