OpenTelemetry Pre-aggregated metrics #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging a3b8fdd into 1f6f3b5 - view on LGTM.com new alerts:
|
heyams
force-pushed
the
heya/pre-aggregated-metrics
branch
from
00c3cd5 to
e7849db
Compare
trask
reviewed
Aug 24, 2022
...nt-bootstrap/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/UserAgents.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerMetrics.java
Outdated
Show resolved
Hide resolved
...otstrap/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/MetricsView.java
Outdated
Show resolved
Hide resolved
...ap/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientMetrics.java
Show resolved
Hide resolved
trask
reviewed
Aug 24, 2022
.../src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MetricDataMapper.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MetricDataMapper.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MetricDataMapper.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MetricDataMapper.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 24, 2022
trask
reviewed
Aug 24, 2022
.../monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/DependencyExtractor.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 24, 2022
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 24, 2022
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 24, 2022
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 24, 2022
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
can you add metric verification to the HttpServer4xx test to verify that we are handling the 4xx configuration setting correctly for metrics?
Contributor
Author
can i leave that to a diff pr? |
trask
reviewed
Aug 25, 2022
...zure/monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/ExtractorHelper.java
Outdated
Show resolved
Hide resolved
...tests/apps/gRPC/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/GrpcTest.java
Outdated
Show resolved
Hide resolved
...tests/apps/gRPC/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/GrpcTest.java
Outdated
Show resolved
Hide resolved
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java
Outdated
Show resolved
Hide resolved
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java
Show resolved
Hide resolved
...ure/monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/RequestExtractor.java
Outdated
Show resolved
Hide resolved
.../monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/DependencyExtractor.java
Outdated
Show resolved
Hide resolved
.../monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/DependencyExtractor.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 25, 2022
.../src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MetricDataMapper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.