Skip to content

Migrated use of CloudFlare font awesome to local paths to remove netw… - #1

Merged
Guy Acosta (guyacosta) merged 1 commit into
masterfrom
UseLocalFontAwesome
Oct 10, 2019
Merged

Migrated use of CloudFlare font awesome to local paths to remove netw…#1
Guy Acosta (guyacosta) merged 1 commit into
masterfrom
UseLocalFontAwesome

Conversation

@guyacosta

Copy link
Copy Markdown
Contributor

Migrated use of Cloud Flare font awesome to local paths to remove network dependency

@daalcant David Alcantar (daalcant) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see any non-cosmetic code touched, overall a good idea for portability too.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this a different way. Rather than embedding the resources as source code, we should consider using Yarn or something like that, and include a manifest file that describes the JavaScript to download during build. That way (a) our dependencies are discoverable; (b) we have a way of easily updating versions; and (c) we keep our repo to "just our code" as much as possible.

End result should be the same -- after build, we'll have local resources.

Longer term, it may make sense to consider just running a local web-server for the content and deprecate the local HTML page. I'll open an issue to keep this on our radar.

@guyacosta

Copy link
Copy Markdown
Contributor Author

Great idea. I had worried about getting out of sync with dependency versions with fixes and more.

@guyacosta

Copy link
Copy Markdown
Contributor Author

I'm going to go ahead and merge this for now until it is reworked to keep aligned with what people were told i.e. that it does not require a network connection to run. Then will replace it.

@guyacosta
Guy Acosta (guyacosta) merged commit d99aba0 into master Oct 10, 2019
@guyacosta
Guy Acosta (guyacosta) deleted the UseLocalFontAwesome branch December 11, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants