Skip to content

Pinning BcContainerHelp and uv versions & switch to process isolation #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sun Haoran (haoranpb) merged 3 commits into from
Apr 24, 2026
Merged

Pinning BcContainerHelp and uv versions & switch to process isolation #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dba907
try pinning BcContainerHelp to 6.1.12
haoranpb Apr 24, 2026
10e6afd
while we are at it, pin uv as well
haoranpb Apr 24, 2026
f2babf6
switch to process isolation to speed up
haoranpb Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-bc-container/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ runs:

- name: Install BcContainerHelper module
if: inputs.skip-container != 'true'
run: Install-Module -Name BcContainerHelper -Force -AllowClobber -AllowPrerelease
run: Install-Module -Name BcContainerHelper -RequiredVersion 6.1.12 -Force -AllowClobber
shell: pwsh

- name: Azure Login with OIDC for cloning internal repository
Expand Down
1 change: 1 addition & 0 deletions .github/actions/setup-python-uv/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ runs:
- name: Install uv
uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57
with:
version: "0.11.7"
enable-cache: true

- name: Setup Python
Expand Down
2 changes: 1 addition & 1 deletion scripts/BCContainerManagement.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ function New-BCContainerSync {
multitenant = $false
shortcuts = 'None'
memoryLimit = "16G"
isolation = "hyperv"
isolation = "process"
}

if ($AcceptEula) {
Expand Down
2 changes: 1 addition & 1 deletion scripts/Setup-ContainerAndRepository.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Invoke-GitCloneWithRetry -RepoUrl $cloneInfo.Url -Token $cloneInfo.Token -CloneP
if (-not $SkipContainer) {
[PSCredential]$credential = Get-BCCredential -Username $Username -Password $Password

Import-Module BcContainerHelper -Force -DisableNameChecking
Import-Module BcContainerHelper -RequiredVersion 6.1.12 -Force -DisableNameChecking

Write-Log "Container name: $ContainerName" -Level Info

Expand Down
2 changes: 1 addition & 1 deletion scripts/Verify-BuildAndTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ if (-not (Test-Path $RepoPath)) {
exit 1
}

Import-Module BcContainerHelper -Force -DisableNameChecking
Import-Module BcContainerHelper -RequiredVersion 6.1.12 -Force -DisableNameChecking

[ValidationResult[]]$validationResults = @()

Expand Down
6 changes: 3 additions & 3 deletions src/bcbench/operations/bc_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def _escape_ps_string(value: str) -> str:
# PowerShell script templates using Python's built-in string.Template
_BUILD_AND_PUBLISH_TEMPLATE = Template(
"""
Import-Module BcContainerHelper -Force -DisableNameChecking
Import-Module BcContainerHelper -RequiredVersion 6.1.12 -Force -DisableNameChecking
Import-Module '$app_utils_path' -Force
$$ErrorActionPreference = 'Stop'

Expand All @@ -44,7 +44,7 @@ def _escape_ps_string(value: str) -> str:

_TEST_EXECUTION_TEMPLATE = Template(
"""
Import-Module BcContainerHelper -Force -DisableNameChecking
Import-Module BcContainerHelper -RequiredVersion 6.1.12 -Force -DisableNameChecking
Import-Module '$app_utils_path' -Force
$$ErrorActionPreference = 'Stop'

Expand All @@ -58,7 +58,7 @@ def _escape_ps_string(value: str) -> str:

_DATASET_TESTS_TEMPLATE = Template(
"""
Import-Module BcContainerHelper -Force -DisableNameChecking
Import-Module BcContainerHelper -RequiredVersion 6.1.12 -Force -DisableNameChecking
Import-Module '$app_utils_path' -Force
$$ErrorActionPreference = 'Stop'

Expand Down
2 changes: 1 addition & 1 deletion tests/test_ps_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_build_app_publish_script_basic(self):
version="1.0.0.0",
)

assert "Import-Module BcContainerHelper -Force -DisableNameChecking" in script
assert "Import-Module BcContainerHelper -RequiredVersion 6.1.12 -Force -DisableNameChecking" in script
assert "$ErrorActionPreference = 'Stop'" in script
assert "ConvertTo-SecureString 'Test123' -AsPlainText -Force" in script
assert "New-Object System.Management.Automation.PSCredential('admin', $password)" in script
Expand Down
Loading