Skip to content

[CH][SEPA CT] Export requires both IBAN and Clearing No. for domestic payments and refunds - #10136

Merged
dcenic merged 12 commits into
mainfrom
bugs/646497SEPACTClearingNoFromIBAN
Aug 17, 2026
Merged

[CH][SEPA CT] Export requires both IBAN and Clearing No. for domestic payments and refunds#10136
dcenic merged 12 commits into
mainfrom
bugs/646497SEPACTClearingNoFromIBAN

Conversation

@dcenic

@dcenic dcenic commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Swiss SEPA CT Export requires both IBAN and Clearing No. for domestic payments and refunds

Expected:
If Clearing No. is blank, it can be extracted from IBAN (IBAN contains it).

What & why

Added the logic that extracts Clearing No. from IBAN, and using it when determining the payment type, and when exporting to MmbId in the SEPA CT file.

Linked work

Fixes AB#646497

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

  • Vendor payment + clearing: identical output → zero risk.
  • Customer refund / vendor-blank-clearing: old output was either invalid (MmbId = IBAN) or nonexistent (errored), so there's nothing valid to break; the fix only makes MmbId schema-correct.
    Since CdtrAcct/IBAN is unchanged and is what routes, no in-flight payment behavior changes — only the redundant MmbId becomes correct.

@dcenic
dcenic requested a review from a team August 11, 2026 10:37
@github-actions github-actions Bot added Team: Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction labels Aug 11, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 11, 2026
Comment thread src/Layers/CH/BaseApp/Local/Bank/Payment/CHMgt.Codeunit.al Outdated
Comment thread src/Layers/CH/BaseApp/Purchases/Vendor/VendorBankAccount.Table.al
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al Outdated
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al Outdated
Comment thread src/Layers/CH/BaseApp/Local/Bank/Payment/CHMgt.Codeunit.al Outdated
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al Outdated
Comment thread src/Layers/CH/BaseApp/Purchases/Vendor/VendorBankAccount.Table.al
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al Outdated
Comment thread src/Layers/CH/BaseApp/Local/Bank/Payment/CHMgt.Codeunit.al
@github-actions

This comment was marked as low quality.

Comment thread src/Layers/CH/Tests/Local/SwissSEPACTExport.Codeunit.al Outdated
Comment thread src/Layers/CH/Tests/Local/SwissSEPACT09Export.Codeunit.al Outdated
dcenic and others added 2 commits August 12, 2026 09:22
Co-authored-by: dcenic <40819937+dcenic@users.noreply.github.com>
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al
Comment thread src/Layers/CH/BaseApp/Purchases/Vendor/VendorBankAccount.Table.al
@github-actions

This comment was marked as resolved.

1 similar comment
@github-actions

This comment was marked as resolved.

ventselartur
ventselartur previously approved these changes Aug 12, 2026
Comment thread src/Layers/CH/Tests/Local/SwissSEPACT09Export.Codeunit.al
@dcenic dcenic added the Team: Finance GitHub request for Finance area label Aug 14, 2026
@github-actions github-actions Bot removed the Team: Finance GitHub request for Finance area label Aug 14, 2026
@dcenic dcenic added the Team: Finance GitHub request for Finance area label Aug 14, 2026
@github-actions github-actions Bot removed the Team: Finance GitHub request for Finance area label Aug 14, 2026
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al
Comment thread src/Layers/CH/BaseApp/Bank/Payment/PaymentExportData.Table.al
@dcenic
dcenic added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit d1bac12 Aug 17, 2026
328 of 336 checks passed
@dcenic
dcenic deleted the bugs/646497SEPACTClearingNoFromIBAN branch August 17, 2026 08:29
pull Bot pushed a commit to Mattlk13/BCApps that referenced this pull request Aug 31, 2026
…_PaymentType3_Negative_BlankedSWIFT fails (microsoft#10720)

[AB#647205](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/647205)



test failed due to change in

[[CH][SEPA CT] Export requires both IBAN and Clearing No. for domestic
payments and refunds by dcenic · Pull Request microsoft#10136 ·
microsoft/BCApps](https://github.com/microsoft/BCApps/pull/10136/changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction Team: Other GitHub request for other area than SCM, Finance or Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants