Add SetReferenceType method to SignedXml and SignedXmlImpl (#10139) - #10212
Open
Marco Antonio Mauro (marcus905) wants to merge 1 commit into
Open
Add SetReferenceType method to SignedXml and SignedXmlImpl (#10139)#10212Marco Antonio Mauro (marcus905) wants to merge 1 commit into
Marco Antonio Mauro (marcus905) wants to merge 1 commit into
Conversation
Marco Antonio Mauro (marcus905)
deployed
to
triage
August 12, 2026 16:29 — with
GitHub Actions
Active
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds support for setting the
Typeproperty on an XMLDSIGReferencethrough the publicSignedXmlcodeunit.SignedXmlalready exposes the reference URI, digest method, and transforms, but not the underlyingReference.Typeproperty. This prevents callers from creating XML signatures that require a typed reference, such as a reference to XAdESSignedProperties.The change adds
SetReferenceType(Type: Text)toSignedXmland its implementation, together with a unit test verifying that the configured value is emitted as theTypeattribute of the generated<Reference>element.Linked work
Fixes #10139
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
SignedXmlModuleTest.Codeunit.althat initializes an XMLDSIG reference, sets itsType, computes the signature, and verifies that the generated<Reference>element contains the expectedTypeattribute.Risk & compatibility
Low risk. The change only adds a new public procedure and delegates it to the existing underlying .NET
Reference.Typeproperty.There are no breaking changes, data or upgrade impacts, permission changes, telemetry changes, or feature flags.