Update expense VAT specification source

src/Apps/W1/ExpenseAgent/app/src/APIs/ExpenseVATSpecAPI.Page.al

@@ -18,6 +18,8 @@ page 7085 "Expense VAT Spec. API"
     ODataKeyFields = SystemId;
     SourceTable = "Expense VAT Specification";
     AboutText = 'Provides access to data from the Expense VAT Specification table';
+    ModifyAllowed = false;
+    DeleteAllowed = false;
     AutoSplitKey = true;
 
     layout
@@ -90,6 +92,7 @@ page 7085 "Expense VAT Spec. API"
                 field(source; Rec.Source)
                 {
                     Caption = 'Source';
+                    Editable = false;
                 }
                 field(confidence; Rec.Confidence)
                 {
@@ -105,4 +108,16 @@ page 7085 "Expense VAT Spec. API"
     begin
         ExpenseAgentAPIValidation.VerifyAgentAccess();
     end;
+
+    trigger OnInsertRecord(BelowxRec: Boolean): Boolean
+    begin
+        InsertVATSpecification(Rec);
+        exit(false);
+    end;
+
+    internal procedure InsertVATSpecification(var ExpenseVATSpecification: Record "Expense VAT Specification")
+    begin
+        ExpenseVATSpecification.Source := ExpenseVATSpecification.Source::Agent;
+        ExpenseVATSpecification.Insert(true);
+    end;
 }

src/Apps/W1/ExpenseAgent/app/src/Expense/Pages/ExpenseVATSpecification.Page.al

@@ -66,4 +66,5 @@ page 7084 "Expense VAT Specification"
             }
         }
     }
+
 }

src/Apps/W1/ExpenseAgent/app/src/Expense/Tables/Expense.Table.al

@@ -800,6 +800,7 @@ table 6900 Expense
         NonRefundableAmountCannotBeNegativeErr: Label '%1 cannot be in negative on Expense No. %2.', Comment = '%1 = Field Caption, %2 = Expense No.';
         ExpenseUserMustBeLinkedToAnEmployeeErr: Label 'Expense User %1 must be linked to an Employee No.', Comment = '%1 = Expense User No.';
         BillableCustomerAndProjectErr: Label 'You cannot use both %1 and %2 at the same time.', Comment = '%1 = Billable to Customer field caption, %2 = Project No. field caption';
+        ModifyOrDeleteErr: Label 'Modifications and delete are not allowed for records created by the Expense Agent API.';
 
     procedure AssistEdit() Result: Boolean
     begin
@@ -1321,6 +1322,7 @@ table 6900 Expense
 
     internal procedure UpdateVATSpecification(ExpenseNo: Code[20])
     var
+        ExpenseCategory: Record "Expense Category";
         ExpenseItemization: Record "Expense Itemization";
         ExpenseVATSpec: Record "Expense VAT Specification";
         TempExpenseVATSpec: Record "Expense VAT Specification" temporary;
@@ -1330,33 +1332,61 @@ table 6900 Expense
         if ExpenseAgentSetup."Default VAT Bus. Posting Group" = '' then
             exit;
 
-        ExpenseItemization.SetRange("Expense No.", ExpenseNo);
-        if ExpenseItemization.IsEmpty() then
-            exit;
-
         ExpenseVATSpec.SetRange("Expense No.", ExpenseNo);
-        ExpenseVATSpec.DeleteAll();
-
-        LineNo := 0;
-        ExpenseItemization.FindSet();
-        repeat
-            TempExpenseVATSpec.SetRange("Expense Category", ExpenseItemization."Expense Category Code");
-            TempExpenseVATSpec.SetRange("Expense Subcategory", ExpenseItemization."Expense Subcategory Code");
-            if TempExpenseVATSpec.FindFirst() then begin
-                TempExpenseVATSpec."Amount" += ExpenseItemization."Amount";
-                TempExpenseVATSpec.Modify();
-            end else begin
-                TempExpenseVATSpec.Init();
-                TempExpenseVATSpec."Expense No." := ExpenseNo;
-                LineNo += 1;
-                TempExpenseVATSpec."Line No." := LineNo;
-                TempExpenseVATSpec.Validate("Expense Category", ExpenseItemization."Expense Category Code");
-                TempExpenseVATSpec.Validate("Expense Subcategory", ExpenseItemization."Expense Subcategory Code");
-                TempExpenseVATSpec.Validate("VAT Bus. Posting Group", ExpenseAgentSetup."Default VAT Bus. Posting Group");
-                TempExpenseVATSpec.Validate("Amount", ExpenseItemization.Amount);
-                TempExpenseVATSpec.Insert();
-            end;
-        until ExpenseItemization.Next() = 0;
+        ExpenseVATSpec.SetRange(Source, ExpenseVATSpec.Source::Agent);
+        if not ExpenseVATSpec.IsEmpty() then
+            error(ModifyOrDeleteErr);
+
+        ExpenseCategory.Get("Expense Category");
+        case ExpenseCategory."Expense Detail Required" of
+            ExpenseCategory."Expense Detail Required"::Itemize:
+                begin
+                    ExpenseItemization.SetRange("Expense No.", ExpenseNo);
+                    if not ExpenseItemization.IsEmpty() then begin
+                        ExpenseVATSpec.SetRange(Source);
+                        ExpenseVATSpec.DeleteAll();
+
+                        LineNo := 0;
+                        ExpenseItemization.FindSet();
+                        repeat
+                            TempExpenseVATSpec.SetRange("Expense Category", ExpenseItemization."Expense Category Code");
+                            TempExpenseVATSpec.SetRange("Expense Subcategory", ExpenseItemization."Expense Subcategory Code");
+                            if TempExpenseVATSpec.FindFirst() then begin
+                                TempExpenseVATSpec.Validate(Amount, TempExpenseVATSpec.Amount + ExpenseItemization.Amount);
+                                TempExpenseVATSpec.Modify();
+                            end else begin
+                                TempExpenseVATSpec.Init();
+                                TempExpenseVATSpec.Source := TempExpenseVATSpec.Source::Manual;
+                                TempExpenseVATSpec."Expense No." := ExpenseNo;
+                                LineNo += 1;
+                                TempExpenseVATSpec."Line No." := LineNo;
+                                TempExpenseVATSpec.Validate("Expense Category", ExpenseItemization."Expense Category Code");
+                                TempExpenseVATSpec.Validate("Expense Subcategory", ExpenseItemization."Expense Subcategory Code");
+                                TempExpenseVATSpec.Validate("VAT Bus. Posting Group", ExpenseAgentSetup."Default VAT Bus. Posting Group");
+                                TempExpenseVATSpec.Validate("Amount", ExpenseItemization.Amount);
+                                TempExpenseVATSpec.Insert();
+                            end;
+                        until ExpenseItemization.Next() = 0;
+                    end;
+                end;
+            else
+                if ExpenseCategory."VAT Prod. Posting Group" <> '' then begin
+                    ExpenseVATSpec.SetRange(Source);
+                    ExpenseVATSpec.DeleteAll();
+
+                    TempExpenseVATSpec.Init();
+                    TempExpenseVATSpec.Source := TempExpenseVATSpec.Source::Manual;
+                    TempExpenseVATSpec."Expense No." := ExpenseNo;
+                    LineNo += 1;
+                    TempExpenseVATSpec."Line No." := LineNo;
+                    TempExpenseVATSpec.Validate("Expense Category", "Expense Category");
+                    if "Expense Subcategory" <> '' then
+                        TempExpenseVATSpec.Validate("Expense Subcategory", "Expense Subcategory");
+                    TempExpenseVATSpec.Validate("VAT Bus. Posting Group", ExpenseAgentSetup."Default VAT Bus. Posting Group");
+                    TempExpenseVATSpec.Validate("Amount", Amount);
+                    TempExpenseVATSpec.Insert();
+                end;
+        end;
 
         TempExpenseVATSpec.Reset();
         if TempExpenseVATSpec.FindSet() then

src/Apps/W1/ExpenseAgent/app/src/Expense/Tables/ExpenseVATSpecification.Table.al

@@ -34,10 +34,12 @@ table 6918 "Expense VAT Specification"
             trigger OnValidate()
             begin
                 GetExpense();
-                if Expense."Expense Category" <> '' then
-                    Validate("Expense Category", "Expense Category");
-                if Expense."Expense Subcategory" <> '' then
-                    Validate("Expense Subcategory", "Expense Subcategory");
+                if Source <> Source::Agent then begin
+                    if Expense."Expense Category" <> '' then
+                        Validate("Expense Category", "Expense Category");
+                    if Expense."Expense Subcategory" <> '' then
+                        Validate("Expense Subcategory", "Expense Subcategory");
+                end;
             end;
         }
         field(2; "Line No."; Integer)
@@ -57,12 +59,14 @@ table 6918 "Expense VAT Specification"
 
             trigger OnValidate()
             begin
-                InitializeCurrency();
-                "VAT Amount" := Round(Amount * "VAT %" / (100 + "VAT %"), Currency."Amount Rounding Precision", Currency.VATRoundingDirection());
-                "VAT Base Amount" := Round(Amount - "VAT Amount", Currency."Amount Rounding Precision");
-                "VAT Difference" := 0;
-                "VAT Amount (LCY)" := CalcVATAmountLCY();
-                "VAT Base Amount (LCY)" := "Amount (LCY)" - "VAT Amount (LCY)";
+                if Source <> Source::Agent then begin
+                    InitializeCurrency();
+                    "VAT Amount" := Round(Amount * "VAT %" / (100 + "VAT %"), Currency."Amount Rounding Precision", Currency.VATRoundingDirection());
+                    "VAT Base Amount" := Round(Amount - "VAT Amount", Currency."Amount Rounding Precision");
+                    "VAT Difference" := 0;
+                    "VAT Amount (LCY)" := CalcVATAmountLCY();
+                    "VAT Base Amount (LCY)" := "Amount (LCY)" - "VAT Amount (LCY)";
+                end;
             end;
         }
         field(11; "VAT Base Amount"; Decimal)
@@ -91,7 +95,8 @@ table 6918 "Expense VAT Specification"
 
             trigger OnValidate()
             begin
-                ValidateAmount();
+                if Source <> Source::Agent then
+                    ValidateAmount();
             end;
         }
         /// <summary>
@@ -151,17 +156,18 @@ table 6918 "Expense VAT Specification"
 
             trigger OnValidate()
             begin
-                GetExpense();
-                if Expense."Currency Code" = '' then begin
-                    Amount := "Amount (LCY)";
-                    Validate(Amount);
-                end else begin
-                    TestField("Amount (LCY)");
-                    TestField(Amount);
-                    Expense."Currency Factor" := Amount / "Amount (LCY)";
+                if Source <> Source::Agent then begin
+                    GetExpense();
+                    if Expense."Currency Code" = '' then begin
+                        Amount := "Amount (LCY)";
+                        Validate(Amount);
+                    end else begin
+                        TestField("Amount (LCY)");
+                        TestField(Amount);
+                        Expense."Currency Factor" := Amount / "Amount (LCY)";
+                    end;
+                    Validate("VAT %");
                 end;
-
-                Validate("VAT %");
             end;
         }
         field(27; "Expense Category"; Code[20])
@@ -174,14 +180,16 @@ table 6918 "Expense VAT Specification"
             var
                 ExpenseCategory: Record "Expense Category";
             begin
-                if "Expense Category" = '' then
-                    exit;
-                if "Expense Subcategory" <> '' then
-                    exit;
-                if ExpenseCategory.Get("Expense Category") then begin
-                    "VAT Prod. Posting Group" := ExpenseCategory."VAT Prod. Posting Group";
-                    "VAT %" := ExpenseCategory."Default VAT %";
-                    Validate("VAT %");
+                if Source <> Source::Agent then begin
+                    if "Expense Category" = '' then
+                        exit;
+                    if "Expense Subcategory" <> '' then
+                        exit;
+                    if ExpenseCategory.Get("Expense Category") then begin
+                        "VAT Prod. Posting Group" := ExpenseCategory."VAT Prod. Posting Group";
+                        "VAT %" := ExpenseCategory."Default VAT %";
+                        Validate("VAT %");
+                    end;
                 end;
             end;
         }
@@ -196,6 +204,9 @@ table 6918 "Expense VAT Specification"
                 ExpenseSubcategory: Record "Expense Subcategory";
                 ExpenseCategory: Record "Expense Category";
             begin
+                if Source = Source::Agent then
+                    exit;
+
                 if "Expense Subcategory" <> '' then begin
                     if ExpenseSubcategory.Get("Expense Category", "Expense Subcategory") then begin
                         "VAT Prod. Posting Group" := ExpenseSubcategory."VAT Prod. Posting Group";
@@ -214,6 +225,8 @@ table 6918 "Expense VAT Specification"
         field(40; Source; Enum "Expense VAT Spec Source")
         {
             Caption = 'Source';
+            Editable = false;
+            DataClassification = SystemMetadata;
             ToolTip = 'Specifies how this VAT specification line was created, for example whether it was entered manually or extracted automatically from a receipt.';
         }
         field(41; Confidence; Decimal)
@@ -249,11 +262,26 @@ table 6918 "Expense VAT Specification"
         end;
     end;
 
+    trigger OnModify()
+    begin
+        TestStatusOpenOfExpense();
+        if Source = Source::Agent then
+            error(ModifyOrDeleteErr);
+    end;
+
+    trigger OnDelete()
+    begin
+        TestStatusOpenOfExpense();
+        if Source = Source::Agent then
+            error(ModifyOrDeleteErr);
+    end;
+
     var
         Currency: Record Currency;
         CurrExchRate: Record "Currency Exchange Rate";
         Expense: Record Expense;
         ExpenseAgentSetup: Record "Expense Agent Setup";
+        ModifyOrDeleteErr: Label 'Modifications and delete are not allowed for records created by the Expense Agent API.';
 
     local procedure CalcVATAmountLCY(): Decimal
     var
@@ -356,4 +384,13 @@ table 6918 "Expense VAT Specification"
         Rec.Reasoning.CreateInStream(InStream, TextEncoding::UTF8);
         InStream.ReadText(Result);
     end;
+
+    local procedure TestStatusOpenOfExpense()
+    var
+        ExpenseRecord: Record Expense;
+    begin
+        ExpenseRecord.SetLoadFields(Status);
+        ExpenseRecord.Get("Expense No.");
+        ExpenseRecord.TestStatusOpen();
+    end;
 }

src/Apps/W1/ExpenseAgent/app/src/ExpenseReport/Codeunits/CreateExpenseReport.Codeunit.al

@@ -177,7 +177,7 @@ codeunit 6983 "Create Expense Report"
         ExpenseReportLine.Validate("Expense User No.", Expense."Expense User No.");
         ExpenseReportLine.Validate("Expense Category", Expense."Expense Category");
         ExpenseReportLine.Validate("Expense Subcategory Code", Expense."Expense Subcategory");
-        ExpenseReportLine.Validate("Expense Location", Expense."Expense Location");
+        ExpenseReportLine.Validate("Expense Location", CopyStr(Expense."Expense Location", 1, 20));
         if Expense.Description <> '' then
             ExpenseReportLine.Validate(Description, Expense.Description);
         if ExpenseReportLine."Expense Subcategory Code" <> '' then
@@ -328,6 +328,8 @@ codeunit 6983 "Create Expense Report"
             ExpenseReportLineVATSpec."VAT Amount" := ExpenseVATSpec."VAT Amount";
             ExpenseReportLineVATSpec.Amount := ExpenseVATSpec.Amount;
             ExpenseReportLineVATSpec."VAT Difference" := ExpenseVATSpec."VAT Difference";
+            ExpenseReportLineVATSpec."Currency Code" := Expense."Currency Code";
+            ExpenseReportLineVATSpec."Currency Factor" := Expense."Currency Factor";
             ExpenseReportLineVATSpec."VAT Bus. Posting Group" := ExpenseVATSpec."VAT Bus. Posting Group";
             ExpenseReportLineVATSpec."VAT Prod. Posting Group" := ExpenseVATSpec."VAT Prod. Posting Group";
             ExpenseReportLineVATSpec."VAT Amount (LCY)" := ExpenseVATSpec."VAT Amount (LCY)";
@@ -341,6 +343,7 @@ codeunit 6983 "Create Expense Report"
             else
                 if ExpenseCategory.Get(ExpenseVATSpec."Expense Category") then
                     ExpenseReportLineVATSpec.Validate("Reclaim %", ExpenseCategory."Default VAT Reclaim %");
+            ExpenseReportLineVATSpec.UpdateReimbursementAmounts();
             ExpenseReportLineVATSpec.Insert();
         until ExpenseVATSpec.Next() = 0;