Updated AL-Go System Files#2
Merged
Merged
Conversation
mazhelez
approved these changes
May 12, 2023
1 task
ChethanT
pushed a commit
that referenced
this pull request
Mar 4, 2026
* Change subscriber from BaseApp to changes generic names (#2) * Warehouse receipt for subcontracting purchase order lines (#1) • Creation of warehouse receipts for each subcontracting purchase line (regardless of whether it is the last operation or not) • Posting the "Warehouse Receipt" posts the purchase order line, which in turn posts the operation of the "Production Order". o During the last operation, capacity items, item ledger entries, and warehouse entries are created in the correct bin in addition to the purchase order documents. A "Warehouse Put-Away" is also created. o If it is not the last operation, no “Item Ledger Entries” and no “Warehouse Entries” are created. Furthermore, no "Warehouse Put-Away" is created. o The "Warehouse Put-Away" for last operation lines can also be posted. • Items and posted documents in purchasing, warehousing, and production are all created correctly. • Partial quantities can be posted at any level. Both in the warehouse receipt and in the warehouse putaway. • Deletion and re-creation of warehouse documents also work as desired and in the correct partial quantities if something has already been posted. • Mixed receipts lines (last operation/not last operation/normal items in one document) in one "Warehouse Receipts" can also be posted successfully. • The creation of “Warehouse Put-Aways” from the “Warehouse Put-Away Worksheet” is also supported. * [Quality Management] - Quality Management Tests failing in CZ (#6238) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Update missing Direct Cost Applied Account #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616057](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/616057/?view=edit) * Exposing Methods For EDocuments (#6221) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> EDocExport.Codeunit.al - Changed IsDocumentTypeSupported from local to procedure (making it public) EDocumentProcessing.Codeunit.al - Removed Access = Internal; property (making the codeunit public) EDocumentWorkFlowProcessing.Codeunit.al - Changed DoesFlowHasEDocService from internal to procedure (making it public) #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #6149 [AB#619113](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/619113) --------- Co-authored-by: tomasevicst <160541867+tomasevicst@users.noreply.github.com> Co-authored-by: Miljan Milosavljević <miljan83@gmail.com> * Warehouse receipt for subcontracting order (#8) * Warehouse receipt for subcontracting purchase order lines (#1) • Creation of warehouse receipts for each subcontracting purchase line (regardless of whether it is the last operation or not) • Posting the "Warehouse Receipt" posts the purchase order line, which in turn posts the operation of the "Production Order". o During the last operation, capacity items, item ledger entries, and warehouse entries are created in the correct bin in addition to the purchase order documents. A "Warehouse Put-Away" is also created. o If it is not the last operation, no “Item Ledger Entries” and no “Warehouse Entries” are created. Furthermore, no "Warehouse Put-Away" is created. o The "Warehouse Put-Away" for last operation lines can also be posted. • Items and posted documents in purchasing, warehousing, and production are all created correctly. • Partial quantities can be posted at any level. Both in the warehouse receipt and in the warehouse putaway. • Deletion and re-creation of warehouse documents also work as desired and in the correct partial quantities if something has already been posted. • Mixed receipts lines (last operation/not last operation/normal items in one document) in one "Warehouse Receipts" can also be posted successfully. • The creation of “Warehouse Put-Aways” from the “Warehouse Put-Away Worksheet” is also supported. * [Subcontracting] Update event subscribers in Whse.-Post Receipt codeunit for improved processing logic (#3) * Add better error message at handling item tracking ehich is related to a subcontracting purchase order line (#4) * Add Second SourceQuantityArray for Purchase Line for Subcontracting Item Tracking * Better Item Tracking Handling and better Errormessage * Change error message * Check connected Purchase Lines at changing routings (#6) * Check connected Purchase Lines at changing routings * correct double line * Changes after code review * test: add integration tests for subcontracting warehouse operations (#5) * test: add integration tests for subcontracting warehouse operations - Create tests for Put-away from Warehouse Receipt and Worksheet. - Implement tests for Last Operation scenarios in warehouse processes. - Ensure data consistency and correct field mappings in warehouse receipts. - Validate base quantity calculations for different units of measure. * refactor: replace PostPutAway calls with RegisterWhseActivity in tests - Updated multiple test cases to use LibraryWarehouse.RegisterWhseActivity instead of SubcWarehouseLibrary.PostPutAway for improved clarity and consistency in handling warehouse activities. * test: enhance subcontracting warehouse tests for item tracking and posting - Add tests to verify item tracking is not allowed for non-last operation purchase lines and warehouse receipt lines. - Implement checks for output quantities in capacity ledger entries. - Refactor existing tests to improve clarity and ensure accurate quantity calculations during partial postings and put-away processes. - Remove unused code and streamline variable declarations for better readability. * fix tests * remove over receipt tests * combine redundant tests * feat: add undo functionality for purchase receipt in last operation tests - Implement tests for undoing purchase receipts, including validation scenarios for when put-away has been registered. - Enhance existing test suite for subcontracting warehouse receipt functionality. * code cleanup * W/pinkow/overreceipt with item tracking in subcontracting (#7) * Remove double Merged Lines * Add Check for over delivery at calling Item Tracking * Corrections * Name correction --------- Co-authored-by: Steven Groß <steven.gross@gob.de> --------- Co-authored-by: tomasevicst <160541867+tomasevicst@users.noreply.github.com> Co-authored-by: Miljan Milosavljević <miljan83@gmail.com> Co-authored-by: Steven Groß <steven.gross@gob.de>
darjoo
pushed a commit
that referenced
this pull request
Apr 6, 2026
…ed-ad4f-43f3-85a4-0b75e238b9b9 Adding Microsoft SECURITY.MD
Groenbech96
pushed a commit
that referenced
this pull request
May 21, 2026
- Fix #1: Clear(AttachmentTempBlob) between attachment record groups to prevent blob data from leaking across attachments - Fix #2: Delete DataExch record in DeleteIntermediateData (was only deleting child rows, leaving the parent record permanently) - Fix #3: Add vendor filter in ResolveAppliesToFromExtInvoiceNo — only filter by vendor when Pay-to Vendor No. is known to avoid over-broad matching - Fix #5: Wrap pipeline in TryFunction so DataExch record and intermediate data are cleaned up even when an error occurs mid-pipeline - Fix #6: Replace hardcoded Error() string in View() with Label constant - Fix #7: Split ProcessFailedErr into UnrecognisedNamespaceErr and DataExchDefNotFoundErr with actionable context per failure mode - Remove V2-MAPPING.md scratch file from resources Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Groenbech96
pushed a commit
that referenced
this pull request
Jun 1, 2026
- Separate stderr capture in Invoke-GhApi to prevent warnings/notices from corrupting JSON output (review #1) - Add --paginate to all gh api calls and switch to NDJSON jq filters (one value per line) so multi-page responses parse correctly. Note: --slurp cannot be combined with --jq so we cannot use that pattern (review #2, #3) - Add timeout-minutes: 10 to the SyncLabel job (review #4) - Pass action inputs (label, whatIf) via environment variables instead of direct GitHub Actions expression interpolation into the pwsh run block, eliminating the script-injection vector (review #5) Not addressed: - review #6 claimed actions/checkout v6.0.2 does not exist; verified via GitHub API that this SHA is tagged v6.0.2, matching the convention used by every other workflow in this repo. Kept as-is for consistency. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Note that when using the preview version of AL-Go for GitHub, you need to Update your AL-Go system files, as soon as possible when told to do so.
Issues
Issue #446 Wrong NewLine character in Release Notes
Issue #453 DeliverToStorage - override fails reading secrets
Issue #434 Use gh auth token to get authentication token instead of gh auth status
Issue #501 The Create New App action will now use 22.0.0.0 as default application reference and include NoImplicitwith feature.
New Settings
UseCompilerFolder: Setting useCompilerFolder to true causes your pipelines to use containerless compiling. Unless you also setdoNotPublishAppsto true, setting useCompilerFolder to true won't give you any performance advantage, since AL-Go for GitHub will still need to create a container in order to publish and test the apps. In the future, publishing and testing will be split from building and there will be other options for getting an instance of Business Central for publishing and testing.vsixFile: vsixFile should be a direct download URL to the version of the AL Language extension you want to use for building the project or repo. By default, AL-Go will use the AL Language extension that comes with the Business Central Artifacts.New Actions
License File
With the changes to the CRONUS license in Business Central version 22, that license can in most cases be used as a developer license for AppSource Apps and it is no longer mandatory to specify a license file in AppSource App repositories.
Obviously, if you build and test your app for Business Central versions prior to 21, it will fail if you don't specify a licenseFileUrl secret.