Conversation
grobyns
reviewed
Sep 12, 2025
src/Apps/W1/PowerBIReports/App/_Obsolete/Sustainability/SetupSustainability.TableExt.al
Outdated
Show resolved
Hide resolved
aholstrup1
added a commit
that referenced
this pull request
Sep 15, 2025
…d numbers (#4760) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> During the Apps (W1) build where we compile, publish and test the add-on apps we start out by creating the container and then we uninstall all apps and unpublish a certain set of apps. The set of apps we unpublish contains the apps under the Apps/W1 folder here in BCApps. Right now, the unpublish step fails in #4757 due to the fact that there are apps that take dependency on the Power BI app. To avoid having to unpublish a lot of apps, we can instead just uninstall all apps but keep the apps published. There is one slight challenge with this though. When we want to publish a new version of App A that takes dependency on App B. If App B is already published to the container in two different versions, it will use the version with the highest version number. Right now, the apps with the highest version numbers are the apps that come with the BC Artifact. To get around this, we can add a runNumberOffset to ensure that the apps produced in BCApps have higher version numbers than the ones on the BC Artifact. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#602818](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602818)
grobyns
reviewed
Sep 16, 2025
src/Apps/W1/PowerBIReports/App/_Obsolete/Core/DimensionSetEntry.Table.al
Outdated
Show resolved
Hide resolved
…res/pbi-to-bcapps
…res/pbi-to-bcapps
…ing to be run when uptaking in NAV, they are only disabled from the BCApps PR pipeline
…/BCApps into features/pbi-to-bcapps
…ith the split of Manufacturing
ventselartur
previously approved these changes
Sep 25, 2025
aholstrup1
approved these changes
Sep 29, 2025
Contributor
aholstrup1
left a comment
aholstrup1
left a comment
There was a problem hiding this comment.
Approved - But let's sync offline to see if we can't get the API tests to run in BCApps as well.
ventselartur
approved these changes
Sep 30, 2025
miljance
pushed a commit
to miljance/BCApps
that referenced
this pull request
Oct 22, 2025
…d numbers (microsoft#4760) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> During the Apps (W1) build where we compile, publish and test the add-on apps we start out by creating the container and then we uninstall all apps and unpublish a certain set of apps. The set of apps we unpublish contains the apps under the Apps/W1 folder here in BCApps. Right now, the unpublish step fails in microsoft#4757 due to the fact that there are apps that take dependency on the Power BI app. To avoid having to unpublish a lot of apps, we can instead just uninstall all apps but keep the apps published. There is one slight challenge with this though. When we want to publish a new version of App A that takes dependency on App B. If App B is already published to the container in two different versions, it will use the version with the highest version number. Right now, the apps with the highest version numbers are the apps that come with the BC Artifact. To get around this, we can add a runNumberOffset to ensure that the apps produced in BCApps have higher version numbers than the ones on the BC Artifact. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#602818](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602818)
miljance
pushed a commit
to miljance/BCApps
that referenced
this pull request
Oct 22, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Moving the Power BI apps to the BCApps repository. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#602534](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602534) --------- Co-authored-by: Diego Joshua Martínez Pineda <diegojoshuam@microsoft.com> Co-authored-by: aholstrup1 <aholstrup@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving the Power BI apps to the BCApps repository.
Work Item(s)
Fixes AB#602534