Keep apps installed during Apps build and add RunNumberOffset to build numbers#4760
Merged
aholstrup1 merged 1 commit intomainfrom Sep 15, 2025
Merged
Conversation
mazhelez
reviewed
Sep 12, 2025
mazhelez
approved these changes
Sep 12, 2025
tomasmsft
approved these changes
Sep 15, 2025
miljance
pushed a commit
to miljance/BCApps
that referenced
this pull request
Oct 22, 2025
…d numbers (microsoft#4760) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> During the Apps (W1) build where we compile, publish and test the add-on apps we start out by creating the container and then we uninstall all apps and unpublish a certain set of apps. The set of apps we unpublish contains the apps under the Apps/W1 folder here in BCApps. Right now, the unpublish step fails in microsoft#4757 due to the fact that there are apps that take dependency on the Power BI app. To avoid having to unpublish a lot of apps, we can instead just uninstall all apps but keep the apps published. There is one slight challenge with this though. When we want to publish a new version of App A that takes dependency on App B. If App B is already published to the container in two different versions, it will use the version with the highest version number. Right now, the apps with the highest version numbers are the apps that come with the BC Artifact. To get around this, we can add a runNumberOffset to ensure that the apps produced in BCApps have higher version numbers than the ones on the BC Artifact. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#602818](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602818)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the Apps (W1) build where we compile, publish and test the add-on apps we start out by creating the container and then we uninstall all apps and unpublish a certain set of apps. The set of apps we unpublish contains the apps under the Apps/W1 folder here in BCApps.
Right now, the unpublish step fails in #4757 due to the fact that there are apps that take dependency on the Power BI app. To avoid having to unpublish a lot of apps, we can instead just uninstall all apps but keep the apps published.
There is one slight challenge with this though. When we want to publish a new version of App A that takes dependency on App B. If App B is already published to the container in two different versions, it will use the version with the highest version number. Right now, the apps with the highest version numbers are the apps that come with the BC Artifact. To get around this, we can add a runNumberOffset to ensure that the apps produced in BCApps have higher version numbers than the ones on the BC Artifact.
Work Item(s)
Fixes AB#602818