EDocument: scope PEPPOL BIS 3.0 .xml file extension to correct document format - #7913
Merged
Jesper Schulz-Wedde (JesperSchulz) merged 1 commit intoJul 2, 2026
Conversation
…rmat The SetFileExt event subscriber in EDocImportPEPPOLBIS30.Codeunit.al unconditionally appended '.xml' to every E-Document Log export, regardless of the Document Format. This caused third-party integrations using a non-PEPPOL format (e.g., json, csv) to receive their exported files with an incorrect .xml extension. The subscriber now: - Only appends '.xml' when the E-Document Log entry has Document Format set to 'PEPPOL BIS 3.0' - Only appends '.xml' when the FileName has no extension already set, so that other subscribers or implementations can override it first No changes to behavior for PEPPOL BIS 3.0 documents when no extension has been set by another subscriber. Closes microsoft#7200
Jeffrey Bulanadi (jeffreybulanadi)
requested a review
from a team
as a code owner
April 30, 2026 09:08
github-actions
Bot
added
AL: Apps (W1)
Jesper Schulz-Wedde (JesperSchulz)
added
the
Team: Integrations
Magnus Hartvig Grønbech (Groenbech96)
added
the
ADO: Sync
Magnus Hartvig Grønbech (Groenbech96)
approved these changes
May 8, 2026
Magnus Hartvig Grønbech (Groenbech96)
left a comment
Magnus Hartvig Grønbech (Groenbech96)
left a comment
Contributor
There was a problem hiding this comment.
You have build errors. My guess is import statements.
Jesper Schulz-Wedde (JesperSchulz)
approved these changes
May 11, 2026
Contributor
|
Build fails with:
|
Contributor
|
Re-running build. |
Jesper Schulz-Wedde (JesperSchulz)
requested a review
from a team
as a code owner
May 18, 2026 11:21
Jesper Schulz-Wedde (JesperSchulz)
enabled auto-merge (squash)
May 18, 2026 11:21
Contributor
|
Pull latest main into branch. |
Contributor
|
Copilot merge main into the branch |
Contributor
|
Retrying CI. |
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
alexei-dobriansky
pushed a commit
that referenced
this pull request
Jul 2, 2026
…nt format (#7913) ## Summary Closes #7200 The SetFileExt event subscriber in EDocImportPEPPOLBIS30.Codeunit.al (codeunit 6166) was unconditionally appending '.xml' to every E-Document Log export, regardless of the Document Format on the E-Document Service. This caused third-party integrations using non-PEPPOL formats (e.g., json, csv) to receive exported files with an incorrect .xml extension. ## Root cause The subscriber appended '.xml' for all Document Formats, not only PEPPOL BIS 3.0. ## Change The subscriber now guards with two conditions before appending '.xml': 1. The E-Document Log entry's Document Format is PEPPOL BIS 3.0 (the only format this codeunit is responsible for) 2. The FileName does not already have a file extension, allowing other subscribers or implementations to set their own extension first ## No breaking changes - PEPPOL BIS 3.0 log exports continue to receive '.xml' when no extension is already set - Other format log exports (Data Exchange, custom) are no longer overridden with '.xml' - The 'using System.IO;' namespace for 'File Management' is already declared in this codeunit Fixes [AB#634372](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/634372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7200
The SetFileExt event subscriber in EDocImportPEPPOLBIS30.Codeunit.al (codeunit 6166) was unconditionally appending '.xml' to every E-Document Log export, regardless of the Document Format on the E-Document Service. This caused third-party integrations using non-PEPPOL formats (e.g., json, csv) to receive exported files with an incorrect .xml extension.
Root cause
The subscriber appended '.xml' for all Document Formats, not only PEPPOL BIS 3.0.
Change
The subscriber now guards with two conditions before appending '.xml':
No breaking changes
Fixes AB#634372