Cloud Migration bug fixes (BC14 reimplementation, custom mapping, OnPrem dev companies)

[nikolakukrika]

Summary

Bug fixes for the Business Central cloud reimplementation / migration tooling (BC14 reimplementation, HybridBaseDeployment custom-migration mapping, and cloud migration management pages).

Fixes AB#641643

Main changes

BC14 reimplementation wizard

• Skip the mapping-tables configuration step in the setup wizard after selecting the company type. BC14MigrationProvider.ShowConfigureMigrationTablesMappingStep() now returns false (matching the interface default), so the wizard no longer shows the custom migration-table mapping step.
• Guard the one-step data upgrade against setup/empty runs. BC14MigrationOrchestrator.TriggerUpgradeIfOneStepEnabled now exits early (with telemetry) when no data was replicated for the run, mirroring the "no data replicated" check used by the GP migration. This prevents an upgrade error being thrown during setup when no companies have been selected/replicated yet.

Custom migration table mapping page (page 40016 "Add Custom Migration Mapping")

• The mapping page can always be closed. Reworked page/close behavior so an invalid mapping no longer blocks closing the page; the target table is validated before the mapping is saved, and the page opens via lookup mode. Converted the page to a Card layout for the single-mapping editing experience.

Cloud migration management pages (OnPrem development)

• New action "OnPrem Development - Insert existing companies as Hybrid Companies" added next to the Enable/Disable OnPrem Development action on both Cloud Migration Management (page 40063) and Intelligent Cloud Management (page 4003). It inserts the environment's existing companies into the Hybrid Company table (idempotently) so they appear in the cloud migration wizard during OnPrem development.

Tests

• Updated BC14MigrationFlowTests to assert the mapping-config step is skipped and added a flow test covering the "no data replicated" one-step upgrade guard.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

AB#642621

[github-actions]

Copilot PR Review

Iteration 2 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Style	1	1	0	0	0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

RestartHistoricalDispatch (BC14CompanyMigrationInfo.table.al) resets the Historical* bookkeeping fields for a rerun but never resets "Current Migration Step" to Historical, while BC14MigrationRunner.RerunHistoricalForCompany flips the company's overall Upgrade Status back to Started via AcquireRerunSlot. On the BC14 Company Upgrade Status page, IsActivelyMigrating(MigrationStep) treats any step other than NotStarted/Completed as active, but since Current Migration Step is left at Completed (its value from the prior successful main migration), the page falls into the 'else' branch and displays the raw 'Started' status with StatusStyle 'Standard' instead of the new 'In Progress' label with StatusStyle 'Strong' that this same PR introduces for actively-migrating companies. This is exactly the scenario the new IsActivelyMigrating feature was built to cover, so an administrator watching the status page during a historical-only rerun sees a company that looks stalled/reverted rather than actively working. Recommend setting Current Migration Step to Historical (or an equivalent 'rerunning' marker) inside RestartHistoricalDispatch, or adding a dedicated bookkeeping flag that IsActivelyMigrating/the page can key off of. This impact would normally warrant a higher severity, but per BCQuality's agent-finding rules severity is capped at minor without a backing knowledge-file citation; treat it as worth promoting to a real defect ticket.

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.12.4}