Fix #607: support older yolov5 versions lacking scale_boxes#659
Open
proofbyhuman wants to merge 1 commit into
Open
Fix #607: support older yolov5 versions lacking scale_boxes#659proofbyhuman wants to merge 1 commit into
proofbyhuman wants to merge 1 commit into
Conversation
yolov5_base.py imported `scale_boxes` from `yolov5.utils.general`, which fails with `ImportError` on older yolov5 releases where the helper is named `scale_coords` (it was later renamed to `scale_boxes` with the same signature). Since `yolov5` is an unpinned dependency, users could end up with either name. Wrap the import in a try/except that falls back to `scale_coords as scale_boxes`, so both older and newer yolov5 versions work. Closes microsoft#607 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PytorchWildlife/models/detection/ultralytics_based/yolov5_base.pyimportedscale_boxesfromyolov5.utils.general, which raisesImportErroron olderyolov5releases where the helper is namedscale_coords. Sinceyolov5is anunpinned dependency (
setup.py,requirements.txt), users can end up witheither name, breaking
import PytorchWildlife.Changes
try/except ImportErrorthat falls back toscale_coords as scale_boxes(same signature), so both older and neweryolov5versions work. No dependency changes required.Testing
Simulated both a "old"
yolov5(onlyscale_coords) and a "new" one (withscale_boxes) and confirmed the import resolvesscale_boxescorrectly in bothcases.
py_compilepasses.Closes #607
AI assistance
Diagnosis and implementation were done with AI assistance (Claude).