Skip to content

Conversation

@tzj-fxz
Copy link
Contributor

@tzj-fxz tzj-fxz commented Oct 21, 2024

  • Tail split support for dynamic matmul

@LeiWang1999
Copy link
Contributor

LeiWang1999 commented Oct 21, 2024

LGTM! Thanks @tzj-fxz , but surprised that we modified tl pass only instead of TIR Transform LoopVectorize. As such approach should also work for a tir script, not only for sake of tl?

@LeiWang1999 LeiWang1999 self-requested a review October 21, 2024 12:11
@LeiWang1999 LeiWang1999 self-assigned this Oct 21, 2024
@LeiWang1999
Copy link
Contributor

LGTM, Merged.

@LeiWang1999 LeiWang1999 merged commit 1fa4620 into microsoft:main Oct 21, 2024
5 of 6 checks passed
@tzj-fxz
Copy link
Contributor Author

tzj-fxz commented Oct 21, 2024

LGTM! Thanks @tzj-fxz , but surprised that we modified tl pass only instead of TIR Transform LoopVectorize. As such approach should also work for a tir script, not only for sake of tl?

In TIR Transform LoopVectorize, vectorizing with dynamic buffer is not allowed and will be replaced by serial read, even if a TailSplit pass is inserted before it.

So I switch to modify tl pass on vectorizing and related dynamic call (like the condition in T.if_then_else which cannot be vectorizedly checked). This can make TIR unaware of the dynamic vectorization and save it from being changed to serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants