Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated application state store. #1721

Merged
merged 5 commits into from Aug 16, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 13, 2019

Resolves #1697

===

This is a huge PR, so here are a couple of notes:

  • The real magic happens in forwardToMain.ts, forwardToRenderer.ts, & store.ts on both main and client
  • The reducers & actions had to be combined and duplicated on both sides. I'm thinking that in a future PR, these could all be moved to the /app/shared/ package so that we only need one copy of each reducer and set of actions
  • Removed a lot of unnecessary code calling between main / renderer to sync data
  • Removed some unused / unnecessary reducer & action code
  • Added missing tests for all state actions (planning to add tests for all state reducers) DONE
@tonyanziano tonyanziano force-pushed the toanzian/state branch from 3cf9e62 to d5cd6cc Aug 13, 2019
@cwhitten

This comment has been minimized.

Copy link
Member

cwhitten commented Aug 15, 2019

@tonyanziano from the description it looks like you still plan to implement some additional tests?

(planning to add tests for all state reducers)

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Aug 15, 2019

@cwhitten Correct, but I was thinking of including them in a separate PR to keep this one as small as possible.

I can include them in this PR though if you'd prefer.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 15, 2019

Coverage Status

Coverage increased (+2.4%) to 65.323% when pulling 452a118 on toanzian/state into 54e8cbe on master.

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Aug 16, 2019

Reducer tests have been added.

@tonyanziano tonyanziano merged commit 889b7d2 into master Aug 16, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #75580 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/state branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.