This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Consolidated application state store.#1721
Merged
Merged
Conversation
3cf9e62 to
d5cd6cc
Compare
Member
|
@tonyanziano from the description it looks like you still plan to implement some additional tests?
|
Contributor
Author
|
@cwhitten Correct, but I was thinking of including them in a separate PR to keep this one as small as possible. I can include them in this PR though if you'd prefer. |
Contributor
Author
|
Reducer tests have been added. |
cwhitten
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1697
===
This is a huge PR, so here are a couple of notes:
forwardToMain.ts,forwardToRenderer.ts, &store.tson both main and client/app/shared/package so that we only need one copy of each reducer and set of actions(planning to add tests for all state reducers)DONE