Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped react & react-dom to 16.8.6 #1939

Merged
merged 3 commits into from Oct 25, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 23, 2019

This is in preparation for when we bump to the next version of Web Chat.

  • bumped react & react-dom to ^16.8.6 to sync with Web Chat
  • fixed bugs that surfaced due to the React bump (OpenBotDialog.tsx)
  • fixed a bug in the <AutoComplete /> component (also tied to OpenBotDialog.tsx)
import 'base64url';
import 'botframework-config/lib/models';
import 'botframework-config/lib/schema';
import 'botframework-webchat';
import 'react';
import 'react-dom';
import 'redux';
import 'redux-promise-middleware';

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Oct 23, 2019

Author Contributor

this was removed as a dependency in #1721 (line where it was removed)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 23, 2019

Coverage Status

Coverage increased (+0.1%) to 67.069% when pulling e32f7c6 on toanzian/react-bump into be33543 on master.

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Oct 23, 2019

A couple of tests blew up. Going to fix those.

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Oct 24, 2019

Need to fix a few components that were relying on (unknowingly) broken getDerivedStateFromProps() functions

@tonyanziano tonyanziano force-pushed the toanzian/react-bump branch 2 times, most recently from fe16983 to 0746000 Oct 25, 2019
@tonyanziano tonyanziano force-pushed the toanzian/react-bump branch from 0746000 to 58a75cc Oct 25, 2019
Copy link
Member

cwhitten left a comment

one nit

@tonyanziano tonyanziano force-pushed the toanzian/react-bump branch from 58a75cc to e32f7c6 Oct 25, 2019
@tonyanziano tonyanziano merged commit ac38931 into master Oct 25, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #86151 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/react-bump branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.