Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Bumped react & react-dom to 16.8.6#1939

Merged
tonyanziano merged 3 commits into
masterfrom
toanzian/react-bump
Oct 25, 2019
Merged

Bumped react & react-dom to 16.8.6#1939
tonyanziano merged 3 commits into
masterfrom
toanzian/react-bump

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

This is in preparation for when we bump to the next version of Web Chat.

  • bumped react & react-dom to ^16.8.6 to sync with Web Chat
  • fixed bugs that surfaced due to the React bump (OpenBotDialog.tsx)
  • fixed a bug in the <AutoComplete /> component (also tied to OpenBotDialog.tsx)

import 'react';
import 'react-dom';
import 'redux';
import 'redux-promise-middleware';
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed as a dependency in #1721 (line where it was removed)

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 23, 2019

Coverage Status

Coverage increased (+0.1%) to 67.069% when pulling e32f7c6 on toanzian/react-bump into be33543 on master.

corinagum
corinagum previously approved these changes Oct 23, 2019
@tonyanziano
Copy link
Copy Markdown
Contributor Author

A couple of tests blew up. Going to fix those.

@tonyanziano
Copy link
Copy Markdown
Contributor Author

Need to fix a few components that were relying on (unknowingly) broken getDerivedStateFromProps() functions

@tonyanziano tonyanziano force-pushed the toanzian/react-bump branch 2 times, most recently from fe16983 to 0746000 Compare October 25, 2019 19:03
cwhitten
cwhitten previously approved these changes Oct 25, 2019
Copy link
Copy Markdown
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

Comment thread packages/app/client/src/ui/shell/explorer/resourceExplorer/resourceExplorer.tsx Outdated
@tonyanziano tonyanziano merged commit ac38931 into master Oct 25, 2019
@tonyanziano tonyanziano deleted the toanzian/react-bump branch October 25, 2019 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants